Skip to content

Conversation

@ssddanbrown
Copy link
Contributor

Just an extra note upon the below: This is my first encounter with Kotlin, and my Android experience is minimal (mostly from a decade ago) so sorry if any of this is poorly done!

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

Updates the checklist reorder moves to filter and just consider those which are visually re-orderable within the UI, since odd behaviour could occur when the fundamental task data had checked items between unchecked items while the "Move checked items to the bottom" setting was enabled. This could occur from toggling the "Move checked items to the bottom" option, or by attempting to move a task item into/below the "Checked items" list.

This also adds a check when moving an item down, since the move handling would consider the "Checked items" as an element when emitting position changes.

Tests performed

  • Manually tested against a Pixel 9a virtual device, and on my actual OnePlus Nord 5 device. Tested sorting various items with and without the "Move checked items" option enabled.

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

Updates the checklist reorder moves to filter and just consider those which are visually re-orderable within the UI, since odd behaviour could occur when the
fundemental task data had checked items between unchecked items while the "Move checked items to the bottom" setting was enabled.
This could occur from toggling the "Move checked items to the bottom" option, or by attempting to move a task item into/below the "Checked items" list.

This also adds a check when moving an item down, since the move handling would consider the "Checked items" as an element when emitting position changes.

Related to FossifyOrg#59
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good 🚀

I fixed a minor changelog issue.

Thanks!

@naveensingh naveensingh merged commit c0f134c into FossifyOrg:main Dec 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reordering checklists works strangely when "Move checked items to the bottom" is checked

2 participants