Skip to content

Conversation

@naveensingh
Copy link
Member

@naveensingh naveensingh commented Dec 27, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Added a new Sound on keypress preference with 3 choices:
    • Off
    • Follow system (this respects system-level sound preference for taps/clicks)
    • Always on (this force plays sound regardless of system settings)
  • This uses built-in effects for keypress, so as with other keyboards, sound doesn't play on all devices.
  • I'll reorganize the preference in another pull request as it's starting to look busy.
  • Refactored the keypress feedback related methods into a KeyboardFeedbackManager class.

Tests performed

  • Key taps with all 3 configurations (on, off, system) on multiple devices.

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh merged commit 6bfa38d into main Dec 27, 2025
8 of 10 checks passed
@naveensingh naveensingh deleted the naveensingh/keypress-sounds branch December 27, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No sound?

2 participants