SDKS-4679 & SDKS-4681: Add Polling and QR Code collectors for DaVinci flows #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flows - Implement `PollingCollector` to handle asynchronous operations like push notifications and OOB authentication, supporting both simple delays and active challenge status polling. - Implement `QRCodeCollector` to handle Base64-encoded QR code images for device pairing and MFA setup. - Add Compose UI components (`Polling.kt`, `QRCode.kt`) and integrate them into `ContinueNode`. - Register new collectors in `CollectorRegistry`. - Add comprehensive unit tests for `PollingCollector` and `QRCodeCollector` logic.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #152 +/- ##
=============================================
+ Coverage 27.26% 27.62% +0.36%
- Complexity 833 853 +20
=============================================
Files 287 289 +2
Lines 8305 8385 +80
Branches 1132 1163 +31
=============================================
+ Hits 2264 2316 +52
- Misses 5799 5801 +2
- Partials 242 268 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @see content | ||
| * @see fallbackText | ||
| */ | ||
| fun bitmap(): Bitmap? { |
Contributor
There was a problem hiding this comment.
Could this be a suspend function as it's doing a Bitmap operation?
Contributor
vibhorgoswami
left a comment
vibhorgoswami
left a comment
There was a problem hiding this comment.
One comment related to bitmap extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-4679
SDKS-4681
Description
PollingCollectorto handle asynchronous operations like push notifications and OOB authentication, supporting both simple delays and active challenge status polling.QRCodeCollectorto handle Base64-encoded QR code images for device pairing and MFA setup.Polling.kt,QRCode.kt) and integrate them intoContinueNode.CollectorRegistry.PollingCollectorandQRCodeCollectorlogic.