Fix heading bug in Style.css #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug which causes certain chapter titles to be stylized incorrectly. (Compare chapter 2 to chapter 3: https://s3.amazonaws.com/moby-dick/moby-dick.epub) Affects <span> elements within <h1-6> elements
Contributor
|
thanks @yh54321 |
hrishikesh-kadam
added a commit
to codetoart/FolioReader-Android
that referenced
this pull request
Dec 10, 2018
Fix font-size issue in FolioReader#309
Contributor
Author
|
I found an error in my fix, it won't work. |
yh54321
added a commit
to yh54321/FolioReader-Android
that referenced
this pull request
Dec 14, 2018
Patches problem in fix PR FolioReader#309. Another solution is to revert FolioReader#309 and to delete line 301 (if it is not needed).
Contributor
|
@yh54321 Yes, exactly. Changes in codetoart@07bee5a would be sufficient. @mahavir155 We can close PR #313 |
Contributor
Author
|
@hrishikesh-kadam Okay, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug which causes certain chapter titles to be stylized incorrectly
(Compare chapter 2 to chapter 3: https://s3.amazonaws.com/moby-dick/moby-dick.epub)
Affects span elements within h1-6 elements