Skip to content

Add protections for loop-bound injections #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christopherholland-workday wants to merge 5 commits into
base: main
Choose a base branch
from
+42 −5
Open

Add protections for loop-bound injections #5849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac8a988
Add protections for loop-bound injections
Feb 25, 2026
b76bccc
Update packages/server/src/services/evaluations/index.ts
christopherholland-workday Feb 25, 2026
99a659d
Update packages/server/src/services/evaluations/index.ts
christopherholland-workday Feb 25, 2026
b0eae70
Add protections for loop-bound injections
Feb 25, 2026
3602b37
Add protections for loop-bound injections
Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/components/evaluation/EvaluationRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ export class EvaluationRunner {

public async runEvaluations(data: ICommonObject) {
const chatflowIds = JSON.parse(data.chatflowId)

if (!Array.isArray(chatflowIds)) {
throw new Error('chatflowId must be a valid array')
}

if (!data.dataset || !Array.isArray(data.dataset.rows)) {
throw new Error('dataset.rows must be a valid array')
}

const returnData: ICommonObject = {}
returnData.evaluationId = data.evaluationId
returnData.runDate = new Date()
Expand Down
5 changes: 5 additions & 0 deletions packages/server/src/services/evaluations/EvaluatorRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ export const runAdditionalEvaluators = async (
selectedEvaluators: string[],
workspaceId: string
) => {
// Validate that inputs are arrays
if (!Array.isArray(actualOutputArray) || !Array.isArray(selectedEvaluators)) {
throw new Error('Invalid input: expected arrays')
}

const evaluationResults: any[] = []
const evaluatorDict: any = {}

Expand Down
33 changes: 28 additions & 5 deletions packages/server/src/services/evaluations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,32 @@ const createEvaluation = async (body: ICommonObject, baseURL: string, orgId: str
const row = appServer.AppDataSource.getRepository(Evaluation).create(newEval)
row.average_metrics = JSON.stringify({})

const chatflowTypes = body.chatflowType ? JSON.parse(body.chatflowType) : []
if (!Array.isArray(chatflowTypes)) {
throw new Error('chatflowType must be a valid array')
}

const simpleEvaluators =
body.selectedSimpleEvaluators && body.selectedSimpleEvaluators.length > 0 ? JSON.parse(body.selectedSimpleEvaluators) : []
if (!Array.isArray(simpleEvaluators)) {
throw new Error('selectedSimpleEvaluators must be a valid array')
}

const additionalConfig: ICommonObject = {
chatflowTypes: body.chatflowType ? JSON.parse(body.chatflowType) : [],
chatflowTypes: chatflowTypes,
datasetAsOneConversation: body.datasetAsOneConversation,
simpleEvaluators: body.selectedSimpleEvaluators.length > 0 ? JSON.parse(body.selectedSimpleEvaluators) : []
simpleEvaluators: simpleEvaluators
}

if (body.evaluationType === 'llm') {
additionalConfig.lLMEvaluators = body.selectedLLMEvaluators.length > 0 ? JSON.parse(body.selectedLLMEvaluators) : []
const lLMEvaluators =
body.selectedLLMEvaluators && body.selectedLLMEvaluators.length > 0 ? JSON.parse(body.selectedLLMEvaluators) : []

if (!Array.isArray(lLMEvaluators)) {
throw new Error('selectedLLMEvaluators must be a valid array')
}

additionalConfig.lLMEvaluators = lLMEvaluators
Comment on lines 75 to 100
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's repetition in parsing and validating arrays from the request body (chatflowTypes, simpleEvaluators, lLMEvaluators). To improve code clarity and maintainability, consider extracting this logic into a helper function. This would also be a good place to handle potential JSON.parse errors with a try-catch block for more specific error messages.

Example:
const parseJsonArray = (input: string | undefined, fieldName: string): any[] => {
if (!input) {
return [];
}
try {
const parsed = JSON.parse(input);
if (!Array.isArray(parsed)) {
throw new Error(${fieldName} must be a valid array);
}
return parsed;
} catch (e) {
throw new Error(Invalid JSON for ${fieldName}: ${e.message});
}
};

References
  1. Prioritize code readability and understandability over conciseness. A series of simple, chained operations can be preferable to a single, more complex one if it improves understandability and reduces the potential for future errors.

additionalConfig.llmConfig = {
credentialId: body.credentialId,
llm: body.llm,
Expand Down Expand Up @@ -123,6 +141,11 @@ const createEvaluation = async (body: ICommonObject, baseURL: string, orgId: str
// When chatflow has an APIKey
const apiKeys: { chatflowId: string; apiKey: string }[] = []
const chatflowIds = JSON.parse(body.chatflowId)

if (!Array.isArray(chatflowIds)) {
throw new Error('chatflowId must be a valid array')
}

for (let i = 0; i < chatflowIds.length; i++) {
const chatflowId = chatflowIds[i]
const cFlow = await appServer.AppDataSource.getRepository(ChatFlow).findOneBy({
Expand Down Expand Up @@ -246,7 +269,7 @@ const createEvaluation = async (body: ICommonObject, baseURL: string, orgId: str
metricsArray,
actualOutputArray,
errorArray,
body.selectedSimpleEvaluators.length > 0 ? JSON.parse(body.selectedSimpleEvaluators) : [],
additionalConfig.simpleEvaluators,
workspaceId
)

Expand All @@ -257,7 +280,7 @@ const createEvaluation = async (body: ICommonObject, baseURL: string, orgId: str

if (body.evaluationType === 'llm') {
resultRow.llmConfig = additionalConfig.llmConfig
resultRow.LLMEvaluators = body.selectedLLMEvaluators.length > 0 ? JSON.parse(body.selectedLLMEvaluators) : []
resultRow.LLMEvaluators = additionalConfig.lLMEvaluators
const llmEvaluatorMap: { evaluatorId: string; evaluator: any }[] = []
for (let i = 0; i < resultRow.LLMEvaluators.length; i++) {
const evaluatorId = resultRow.LLMEvaluators[i]
Expand Down
Loading