feat: #5639 Add Check/Uncheck All buttons to credential sharing#5757
feat: #5639 Add Check/Uncheck All buttons to credential sharing#5757KUNDAN1334 wants to merge 4 commits intoFlowiseAI:mainfrom
Conversation
Summary of ChangesHello @KUNDAN1334, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for sharing credentials by adding 'Check All' and 'Uncheck All' functionality to the workspace selection dialog. This improvement allows users to quickly manage sharing permissions across multiple workspaces with a single click, reducing manual effort and improving efficiency. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful 'Check All' and 'Uncheck All' feature to the credential sharing dialog, which will significantly improve the user experience when dealing with many workspaces. The implementation is straightforward. I've identified one functional bug where the 'Check All' button's state doesn't sync correctly when individual rows are toggled. I've also included a couple of suggestions for code cleanup and to further enhance the UI's responsiveness. Overall, a great addition with a few adjustments needed.
packages/ui/src/ui-component/dialog/ShareWithWorkspaceDialog.jsx
Outdated
Show resolved
Hide resolved
packages/ui/src/ui-component/dialog/ShareWithWorkspaceDialog.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…tps://github.com/KUNDAN1334/Flowise into Add-(Un)Check-All-buttons-for-credential-sharing
Fixes #5639
Before: Manual scroll/uncheck 50+ workspaces
After: 1-click Check All/Uncheck All
Changes
Check All ({outputSchema.length})