fix: #5736 Navigate to canvas after FlowListTable rename#5754
fix: #5736 Navigate to canvas after FlowListTable rename#5754KUNDAN1334 wants to merge 4 commits intoFlowiseAI:mainfrom
Conversation
Summary of ChangesHello @KUNDAN1334, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the flow renaming functionality to enhance user experience by directly navigating to the canvas editor after a successful rename, rather than returning to the list view. It streamlines the API request payload, integrates user feedback with snackbar notifications, and ensures correct routing for various flow types, improving the overall workflow for managing chatflows and agentflows. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully implements the navigation to the canvas editor after a flow is renamed from the list view. It also cleans up the API payload. However, there are some minor issues regarding code style consistency (semicolons), unnecessary whitespace, and UI state management (closing the dialog) that should be addressed to maintain code quality. Additionally, the 'updateBody' variable (lines 183-186) is now unused and should be removed.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Before: Rename from List View → returns to chatflows list
After: Rename from List View → navigates to canvas editor
Changes
updateFlowsApi.request()table refresh after renameuseNavigate()to/canvas/${chatflow.id}(or agentcanvas routes){ name: chatflowName }(removed extrachatflowprop)useNavigatehook placement (inside component)