Fix chat input: IME, ArrowUp/Down history, and Enter behavior#5743
Fix chat input: IME, ArrowUp/Down history, and Enter behavior#5743devshah23 wants to merge 2 commits intoFlowiseAI:mainfrom
Conversation
Summary of ChangesHello @devshah23, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the chat input experience within the Flowise UI. It addresses several long-standing issues related to Input Method Editors (IMEs), refines the behavior of arrow keys for navigating input history, and standardizes the Enter and Shift+Enter key actions. The changes aim to make the chat input more intuitive, robust, and consistent with user expectations for text input fields, particularly benefiting users who rely on IMEs or frequently use multi-line messages. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements to the chat input, fixing issues with IME, arrow key history navigation, and Enter key behavior. The changes make the chat experience more intuitive and predictable. The logic for handling input history has also been corrected to ensure all submitted messages are stored. The code is cleaner and more robust. I've pointed out a couple of minor formatting issues that could be addressed to further improve code quality.
Fixes
Fixes #5662
Description
This PR improves the chat input experience in Flowise UI, addressing issues with IME and input history: