-
Notifications
You must be signed in to change notification settings - Fork 468
fix: Webhook payloads do not include multivariate values #6666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
aa7a6b5 to
aa79ef9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6666 +/- ##
==========================================
+ Coverage 98.20% 98.22% +0.01%
==========================================
Files 1298 1313 +15
Lines 47108 47481 +373
==========================================
+ Hits 46262 46636 +374
+ Misses 846 845 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 NIT and a comment, otherwise clean
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #6190.
In this PR, we add
multivariate_feature_state_valuesto environment webhook payloads forFLAG_UPDATEDevents. The payload now includes each multivariate option's ID, value, and percentage allocation in bothnew_stateandprevious_state:The documentation and sample webhook value are updated accordingly.
How did you test this code?
Added an integration test reproducing the issue, and will test in staging.