Skip to content

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Feb 2, 2026

Changes

Upgrade to python 3.13

Note that we had previously attempted to upgrade to python 3.12 back in June 2024, which caused issues as described in this issue. Having researched it further, I believe that this was caused by the fact that we were still running django 3.2.25 at the time. We are now on django 5 which should support python 3.12+ (relevant SO comment here).

How did you test this code?

  1. Added python 3.13 to unit testing matrix
  2. Docker based E2E tests
  3. Once merged, we'll test and monitor in staging

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Feb 6, 2026 5:47pm
flagsmith-frontend-preview Ignored Ignored Preview Feb 6, 2026 5:47pm
flagsmith-frontend-staging Ignored Ignored Preview Feb 6, 2026 5:47pm

Request Review

@github-actions github-actions bot added dependencies Pull requests that update a dependency file api Issue related to the REST API and removed dependencies Pull requests that update a dependency file labels Feb 2, 2026
@matthewelwell matthewelwell force-pushed the deps/support-python-3.13 branch from bae80a8 to 2008432 Compare February 3, 2026 12:46
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.22%. Comparing base (0a2464b) to head (e2ca6f9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6645   +/-   ##
=======================================
  Coverage   98.21%   98.22%           
=======================================
  Files        1313     1313           
  Lines       47421    47481   +60     
=======================================
+ Hits        46576    46636   +60     
  Misses        845      845           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Feb 3, 2026
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Feb 6, 2026
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Feb 6, 2026
@matthewelwell matthewelwell marked this pull request as ready for review February 6, 2026 17:54
@matthewelwell matthewelwell requested review from a team as code owners February 6, 2026 17:54
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team February 6, 2026 17:54
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6645 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6645 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6645 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6645 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6645 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6645 Finished ✅ Results

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀! One minor question to maybe 🚀🚀

@matthewelwell matthewelwell merged commit 7d39204 into main Feb 9, 2026
53 checks passed
@matthewelwell matthewelwell deleted the deps/support-python-3.13 branch February 9, 2026 13:37
@matthewelwell
Copy link
Contributor Author

Heads up that I have tested SMTP email delivery manually using https://mailtrap.io/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants