Improve tool calling response handling

[MichaelAnders]

Summary

• Additional logging for tool call parsing and execution
• Hard-coded shell commands for reliable tool execution
• Deduplication of tool calls within a single response
• Collect and return results from all called tools
• Ollama uses specified Ollama model
• Fix double-serialized JSON parameters from some providers
• Fix stripThinkingBlocks() destroying markdown bullet points in Ollama responses
• Handle Ollama offline gracefully with retry and 503 response
• Add optional TOPIC_DETECTION_MODEL env var to redirect topic detection to a lighter model
• Add optional SUGGESTION_MODE_MODEL env var to control suggestion mode LLM calls (none to disable, or redirect to other model)
• Remove tool_result_direct short-circuit and improve agentic loop
• Add external file read with tilde expansion and user approval flow
• Improve tool calling response handling for Ollama models

Problems

• Topic detection requests use the same large model as the main request. For users running local models, this adds unnecessary GPU load for a simple classification task.
• Several issues with the agentic loop and Ollama integration:

1. stripThinkingBlocks() was destroying valid response content - The regex matched standard markdown bullets as "thinking markers", causing most list-based responses to be truncated after the first heading.
2. Suggestion mode uses GPU resources - Every user message triggers a full agentic loop with tools for suggestion prediction, blocking responses on large models (70b+).
3. Tool calling response handling had edge cases with Ollama's response format.

Configuration for TOPIC_DETECTION_MODEL

# Use main model (default, unchanged behavior)
TOPIC_DETECTION_MODEL=default

# Redirect to a lighter model
TOPIC_DETECTION_MODEL=llama3.2:1b

Files Changed

File	Change
src/api/middleware/logging.js	Enhanced request/response logging
src/api/middleware/request-logging.js	Additional request logging
src/api/router.js	Router updates for tool handling
src/config/index.js	Ollama model configuration, added TOPIC_DETECTION_MODEL env var (default: "default"), wired into config object and reloadConfig() for hot reload support
src/orchestrator/index.js	Tool call deduplication, result collection, direct result return
src/tools/index.js	Deep-parse double-serialized JSON params, execution logging
src/tools/stubs.js	AskUserQuestion handler improvements
src/tools/workspace.js	Workspace tool updates

Test plan

• Verify tool calls are deduplicated when model returns duplicates
• Verify results from all called tools are collected and returned
• Verify Ollama uses the configured model
• Verify double-serialized JSON parameters (e.g. stringified arrays) are correctly parsed
• Verified markdown bullet points survive in Ollama responses (the original bug)
• Tested Ollama offline/online transitions
• Tested suggestion mode disable (SUGGESTION_MODE_MODEL=none)

[vishalveerareddy123]

Can you please add .env.example file as well.

[MichaelAnders]

Can you please add .env.example file as well.

Done!

[veerareddyvishal144]

@MichaelAnders
Looks like this one is repeated
Can you please check

[MichaelAnders]

Good catch! You were right — the Ollama else if branch was incorrectly nested inside the OpenAI deduplication if (toolCalls.length > 0) block, which caused the OpenAI parsing + dedup code to appear twice (once at the outer level and again as the else fallback).

Fixed in 62a0710 by restructuring so all three provider branches (Anthropic, Ollama, OpenAI/Databricks) are siblings at the same nesting level, each with their own deduplication logic. The duplicate OpenAI block is removed.

[veerareddyvishal144]

When I run this pr
I get the following error

npm start

> lynkr@7.2.5 prestart
> node -e "if(process.env.HEADROOM_ENABLED==='true'&&process.env.HEADROOM_DOCKER_ENABLED!=='false'){process.exit(0)}else{process.exit(1)}" && docker compose --profile headroom up -d headroom 2>/dev/null || echo 'Headroom skipped (disabled or Docker not running)'

Headroom skipped (disabled or Docker not running)

> lynkr@7.2.5 start
> node index.js 2>&1 | npx pino-pretty --sync

[CONFIG] Tool execution mode: client
/Users/vishalveera.reddy/claude-code/src/orchestrator/index.js:2097
    const toolsWereSent = Array.isArray(cleanPayload.tools) && cleanPayload.tools.length > 0;
          ^

SyntaxError: Identifier 'toolsWereSent' has already been declared
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1153:20)
    at Module._compile (node:internal/modules/cjs/loader:1205:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/Users/vishalveera.reddy/claude-code/src/api/router.js:2:28)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)

Node.js v20.9.0

[veerareddyvishal144]

const toolsWereSent this one is declared twice