Make FOSS tests more convenient to use#169
Open
furtib wants to merge 11 commits intoEricsson:mainfrom
Open
Conversation
218b0ef to
86d6d8a
Compare
Szelethus
reviewed
Feb 3, 2026
test/common/tmpfile.py
Outdated
| import tempfile | ||
|
|
||
|
|
||
| class TemporaryDir: |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I was not aware of this. Fixed.
86d6d8a to
f74ec27
Compare
Szelethus
requested changes
Feb 23, 2026
Contributor
Szelethus
left a comment
There was a problem hiding this comment.
I'd prefer to have a bit more verbosity from the unit test, e.g. "Setting up project XYZ...". I'm running pytest test/foss/ --capture=no and seeing nothing.
@nettle, since you mentioned as an annoying issue, what do you think of this rework?
| - Clone the test project into a folder, its path will be the first command line argument. | ||
| - To ensure the project doesn't change over time, check out a specific tag or commit instead of a branch! | ||
| - Copy the .bazelversion file from the templates directory into the test-proj directory. | ||
| - Copy the .bazelversion file, if it exists, from the root of codechecker_bazel into the projects directory. |
Contributor
There was a problem hiding this comment.
Reading only the documentation it might not be obvious when does it ever exist.
Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
d68c96a to
f977090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
FOSS tests left behind a lot of artifacts, which in certain cases blocked the test from running (e.g., after changing bazel version).
What:
README.mdto reflect these changesAddresses:
#148