Skip to content

Conversation

@markatosi
Copy link

Added sections for macOS

Added profiles for ASP.NET and Console applications on macOS.
Copilot AI review requested due to automatic review settings December 13, 2025 22:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds macOS-specific sections to the project's wiki documentation related to package building. The changes include version updates, new migration check targets, expanded test coverage, enhanced API functionality, and comprehensive documentation updates across multiple entity files.

  • Version bumped from 0.2.0 to 0.3.0 across the codebase
  • Added ElectronNET.MigrationChecks.targets file for build validation
  • Enhanced WebContents and Tray APIs with new methods for zoom, audio, DevTools, and user agent management
  • Updated numerous entity classes with comprehensive documentation and platform-specific attributes

Reviewed changes

Copilot reviewed 192 out of 194 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/common.props Version increment to 0.3.0
src/ElectronNET/build/ElectronNET.MigrationChecks.targets New migration validation checks for build configurations
src/ElectronNET/build/ElectronNET.LateImport.targets Updated electron-builder output directory configuration
src/ElectronNET/build/ElectronNET.Core.targets Imports new migration checks target
src/ElectronNET/ElectronNET.csproj Disabled nullable reference types
src/ElectronNET.API/* Extensive entity documentation updates with platform-specific attributes
src/ElectronNET.Host/api/webContents.* New WebContents methods for zoom, audio, and DevTools
src/ElectronNET.IntegrationTests/* Test refactoring with new base class and enhanced coverage
Comments suppressed due to low confidence (9)

src/ElectronNET.WebApp/Properties/PublishProfiles/win-x64.pubxml:1

  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.WebApp/Properties/PublishProfiles/linux-x64.pubxml:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.WebApp/ElectronNET.WebApp.csproj:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.Samples.ElectronHostHook/ElectronNET.Samples.ElectronHostHook.csproj:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.ConsoleApp/Properties/PublishProfiles/win-x64.pubxml:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.ConsoleApp/Properties/PublishProfiles/publish-win-x64.pubxml:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.ConsoleApp/Properties/PublishProfiles/linux-x64.pubxml:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj:1
  • .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
    src/ElectronNET.API/API/Entities/PrintOptions.cs:1
  • The type of the Copies property was changed from bool to int. This is correct per the Electron API documentation, but this is a breaking change that could cause compilation errors in existing code that assigns boolean values to this property.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@markatosi markatosi changed the base branch from main to develop December 13, 2025 22:43
Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@FlorianRappl FlorianRappl added this to the 0.3.0 milestone Dec 13, 2025
@FlorianRappl FlorianRappl merged commit f148fe6 into ElectronNET:develop Dec 13, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants