-
-
Notifications
You must be signed in to change notification settings - Fork 746
Wiki Package building macOS sections added #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added profiles for ASP.NET and Console applications on macOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds macOS-specific sections to the project's wiki documentation related to package building. The changes include version updates, new migration check targets, expanded test coverage, enhanced API functionality, and comprehensive documentation updates across multiple entity files.
- Version bumped from 0.2.0 to 0.3.0 across the codebase
- Added ElectronNET.MigrationChecks.targets file for build validation
- Enhanced WebContents and Tray APIs with new methods for zoom, audio, DevTools, and user agent management
- Updated numerous entity classes with comprehensive documentation and platform-specific attributes
Reviewed changes
Copilot reviewed 192 out of 194 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/common.props | Version increment to 0.3.0 |
| src/ElectronNET/build/ElectronNET.MigrationChecks.targets | New migration validation checks for build configurations |
| src/ElectronNET/build/ElectronNET.LateImport.targets | Updated electron-builder output directory configuration |
| src/ElectronNET/build/ElectronNET.Core.targets | Imports new migration checks target |
| src/ElectronNET/ElectronNET.csproj | Disabled nullable reference types |
| src/ElectronNET.API/* | Extensive entity documentation updates with platform-specific attributes |
| src/ElectronNET.Host/api/webContents.* | New WebContents methods for zoom, audio, and DevTools |
| src/ElectronNET.IntegrationTests/* | Test refactoring with new base class and enhanced coverage |
Comments suppressed due to low confidence (9)
src/ElectronNET.WebApp/Properties/PublishProfiles/win-x64.pubxml:1
- .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.WebApp/Properties/PublishProfiles/linux-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.WebApp/ElectronNET.WebApp.csproj:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.Samples.ElectronHostHook/ElectronNET.Samples.ElectronHostHook.csproj:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/Properties/PublishProfiles/win-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/Properties/PublishProfiles/publish-win-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/Properties/PublishProfiles/linux-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.API/API/Entities/PrintOptions.cs:1 - The type of the
Copiesproperty was changed frombooltoint. This is correct per the Electron API documentation, but this is a breaking change that could cause compilation errors in existing code that assigns boolean values to this property.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FlorianRappl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Added sections for macOS