Infinite: Update to new API spec, final touchups #5916
Conversation
`/customer` endpoint changed `personalInfo` -> `individualData`
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
from
fb5284e to
eb5b925
Compare
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
2 times, most recently
from
8696a2d to
fd06d7a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd06d7a4eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Jon-edge
changed the title
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
from
fd06d7a to
f9c6477
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
from
f9c6477 to
0b987ef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Jon-edge
changed the title
Jon-edge
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b987ef1bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Previously only gave the option to go back to the `RampSelectOptionScene` when the KYC was incomplete.
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
from
0b987ef to
83e4a8e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const [firstName, setFirstName] = React.useState(initialFirstName) | ||
| const [lastName, setLastName] = React.useState(initialLastName) | ||
| const [email, setEmail] = React.useState(initialEmail) | ||
| const [phone, setPhone] = React.useState(initialPhone) |
There was a problem hiding this comment.
Phone field mishandles E.164 format initial values
Medium Severity
The initialPhone parameter doesn't convert E.164 format (+14155551234) to display format. If provided in E.164 format, it displays incorrectly with double country codes (+1 +14155551234) and submits as invalid E.164 (+114155551234) because phoneToE164 blindly prepends +1 to all digits without checking for an existing country code.
Additional Locations (1)
| }) | ||
| .catch(reject) | ||
| } | ||
| : undefined, |
There was a problem hiding this comment.
Complete KYC button allows concurrent operations
Low Severity
The onComplete callback starts async operations but doesn't return the Promise chain, so RampPendingScene treats it as synchronous. Rapid button clicks could trigger multiple concurrent webview opens and status checks before the first webview appears, potentially causing race conditions or duplicate navigation operations.
Additional Locations (1)
| // instead of a modal in the event there is no region selected. | ||
| useFocusEffect( | ||
| React.useCallback(() => { | ||
| onRegionSelect().catch(() => {}) |
There was a problem hiding this comment.
Silent error suppression in region selection
Low Severity
The useFocusEffect hook silently catches and ignores all errors from onRegionSelect() with an empty catch handler. This could mask important failures like network errors, API issues, or navigation problems, making debugging difficult when the region selection modal fails to open.
TODO: Replace the entire instructional scene with a country selection list instead of a modal in the event there is no region selected. Excess instruction manuals and modals should be avoided and this is a place it can easily be avoided.
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
from
83e4a8e to
7dc63b1
Compare
"Account Name" confusing. Renamed to "Account Nickname"
Jon-edge
force-pushed
the
jon/fix/hopefully-final-infinite-api
branch
from
7dc63b1 to
00d27e2
Compare
More surprise API changes from Infinite, integrate to allow KYC form submission on Edge's side:
/customerendpoint changedpersonalInfo->individualDataProperly pre-populate nationality
Add extended form input (DOB, SSN, etc) and supporting UI
Fix draft/pending KYC workflow (going back on incomplete web form KYC) to allow revisiting the KYC url.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Modernizes the Ramp KYC experience and aligns with Infinite’s latest API.
individualDatawithfirstName/lastName/nationality/phone/dateOfBirth/taxIdentificationNumber; handle newDRAFTstatus; update KYC workflow to send extended fields and nationality; enhance pending flow to support re-opening KYC via optional webview action and re-polling.RampKycFormScenewith phone, DOB (picker + validation), and SSN fields, input formatting/validation, and sectioned layout; integrates into DevTestScene; adds new form field typesphoneandssn.RampRegionSelectauto-opens region selector on focus;RampPendingScenecan show a "Complete KYC" button when applicable.Written by Cursor Bugbot for commit 83e4a8e. This will update automatically on new commits. Configure here.