Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Jan 19, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Strengthens Simplex order status handling and observability.

  • Refines success status detection in the Simplex deeplink handler within simplexRampPlugin.ts
  • Adds debug logs for the external webview URL and incoming deeplink payload to aid troubleshooting
  • Updates CHANGELOG.md to note the Simplex success status detection fix

Written by Cursor Bugbot for commit 4c1a4cf. This will update automatically on new commits. Configure here.


@Jon-edge Jon-edge force-pushed the jon/fix/simplex-tracking branch from f36d996 to 7fb795d Compare January 21, 2026 18:43
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 5 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

},
onClose: () => {
console.log(`[Simplex DEBUG] WebView closed by user`)
return true // Allow close
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug console.log statements left in production code

Medium Severity

Multiple console.log statements with [Simplex DEBUG] prefix are present throughout the code, along with comments explicitly stating "Temporarily using guiPluginWebView for debugging". This debugging code should not be committed to production.

Additional Locations (1)

Fix in Cursor Fix in Web

lstrings.fiat_plugin_buy_failed_try_again,
NOT_SUCCESS_TOAST_HIDE_MS
)
navigation.pop()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing default case for unknown transaction statuses

Medium Severity

The old implementation had a default case in the switch statement that showed fiat_plugin_buy_unknown_status toast and called navigation.pop() when Simplex returned an unrecognized status. The new implementation only handles success and failure patterns. If Simplex returns an unexpected status (e.g., status=pending or status=cancelled), the user receives no feedback and the webview doesn't close properly.

Fix in Cursor Fix in Web

@Jon-edge Jon-edge force-pushed the jon/fix/simplex-tracking branch from 7fb795d to 4c1a4cf Compare January 21, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants