-
Notifications
You must be signed in to change notification settings - Fork 279
Fix Simplex tracking #5910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix Simplex tracking #5910
Conversation
f36d996 to
7fb795d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }, | ||
| onClose: () => { | ||
| console.log(`[Simplex DEBUG] WebView closed by user`) | ||
| return true // Allow close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug console.log statements left in production code
Medium Severity
Multiple console.log statements with [Simplex DEBUG] prefix are present throughout the code, along with comments explicitly stating "Temporarily using guiPluginWebView for debugging". This debugging code should not be committed to production.
Additional Locations (1)
| lstrings.fiat_plugin_buy_failed_try_again, | ||
| NOT_SUCCESS_TOAST_HIDE_MS | ||
| ) | ||
| navigation.pop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing default case for unknown transaction statuses
Medium Severity
The old implementation had a default case in the switch statement that showed fiat_plugin_buy_unknown_status toast and called navigation.pop() when Simplex returned an unrecognized status. The new implementation only handles success and failure patterns. If Simplex returns an unexpected status (e.g., status=pending or status=cancelled), the user receives no feedback and the webview doesn't close properly.
7fb795d to
4c1a4cf
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Strengthens Simplex order status handling and observability.
simplexRampPlugin.tsCHANGELOG.mdto note the Simplex success status detection fixWritten by Cursor Bugbot for commit 4c1a4cf. This will update automatically on new commits. Configure here.