Skip to content

ECWID-169535: Added new fields in OrderItem object. #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VHripsime merged 2 commits into from
Aug 12, 2025
Merged

ECWID-169535: Added new fields in OrderItem object. #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c5ed26
Merge remote-tracking branch 'origin/master'
VHripsime Aug 12, 2025
2524c41
ECWID-169535: Added new fields in OrderItem object.
VHripsime Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/cart/request/OrderForCalculate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ data class OrderForCalculate(
val price: Double? = null,
val productPrice: Double? = null,
val needCalculateWholesalePrice: Boolean? = null,
val isCustomerSetPrice: Boolean? = null,
val selectedPrice: SelectedPrice? = null,
val shipping: Double? = null,
val tax: Double? = null,
val fixedShippingRate: Double? = null,
Expand Down Expand Up @@ -275,4 +277,8 @@ data class OrderForCalculate(
data class PaymentOption(
val paymentId: String? = null,
)

data class SelectedPrice(
val value: Double? = null
)
}
2 changes: 1 addition & 1 deletion src/test/kotlin/com/ecwid/apiclient/v3/DtoContractUnitTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class DtoContractUnitTest {
@Test
@Order(5)
fun `test no new exclusions added to file NullablePropertyRules`() {
val expectedNullablePropertiesCount = 931
val expectedNullablePropertiesCount = 933
val ignoreNullablePropertiesCount = nullablePropertyRules
.filterIsInstance<IgnoreNullable<*, *>>()
.size
Expand Down
3 changes: 3 additions & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/OrderForCalculateRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ val orderForCalculateNullablePropertyRules: List<NullablePropertyRule<*, *>> = l
IgnoreNullable(OrderForCalculate.OrderItem::price),
IgnoreNullable(OrderForCalculate.OrderItem::productId),
IgnoreNullable(OrderForCalculate.OrderItem::productPrice),
IgnoreNullable(OrderForCalculate.OrderItem::isCustomerSetPrice),
IgnoreNullable(OrderForCalculate.OrderItem::selectedPrice),
IgnoreNullable(OrderForCalculate.OrderItem::quantity),
IgnoreNullable(OrderForCalculate.OrderItem::quantityInStock),
IgnoreNullable(OrderForCalculate.OrderItem::selectedOptions),
Expand Down Expand Up @@ -125,6 +127,7 @@ val orderForCalculateNullablePropertyRules: List<NullablePropertyRule<*, *>> = l
IgnoreNullable(OrderForCalculate.OrderItemTax::total),
IgnoreNullable(OrderForCalculate.OrderItemTax::value),
AllowNullable(OrderForCalculate.PaymentOption::paymentId),
AllowNullable(OrderForCalculate.SelectedPrice::value),
IgnoreNullable(OrderForCalculate.PersonInfo::city),
IgnoreNullable(OrderForCalculate.PersonInfo::companyName),
IgnoreNullable(OrderForCalculate.PersonInfo::countryCode),
Expand Down