Open
Conversation
- cyan for informational - green for passed - yellow for inconclusive - red for failed
Previous implementation never output colors for me
Contributor
Author
|
@amirrajan I am ok not receiving copyright credit in the source file for this, but I'm not clear how to mark that for this PR. Is there a particular notation I should use? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running tests on my game and noticed they had no colors - this seemed like an easy improvement to make it easier to parse visually, so I added some.
As I was trying to validate the change, I discovered that none of my color codes were working... I am not sure if my terminal is misconfigured (I don't believe it is? Fairly stock iTerm on OS X) or not, but I've included the commit with changes I had to make to
log_with_colorto get it working as well.Screenshot (the non-colorized outputs are from
putsstatements in my code):