Fixes 9 instance of code causing IDE0038#3952
Open
jsrustad wants to merge 2 commits intoDotNetAnalyzers:masterfrom
Open
Fixes 9 instance of code causing IDE0038#3952jsrustad wants to merge 2 commits intoDotNetAnalyzers:masterfrom
jsrustad wants to merge 2 commits intoDotNetAnalyzers:masterfrom
Conversation
Refactor: Use pattern matching for type checks Refactored code to utilize C# pattern matching with the `is` keyword for type checking and casting, eliminating explicit casts. - Updated `ElementOrderCodeFixProvider.cs` to use pattern matching for `TypeDeclarationSyntax` and `CompilationUnitSyntax`. - Refactored `Equals` method in `UsingCodeFixProvider.TreeTextSpan.cs` to use pattern matching. - Applied pattern matching in `DeclarationModifiersHelper.cs` for various syntax types, improving readability and maintainability.
jsrustad
changed the title
jsrustad
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3952 +/- ##
==========================================
+ Coverage 94.60% 97.46% +2.85%
==========================================
Files 1026 1026
Lines 119110 119137 +27
Branches 3475 3475
==========================================
+ Hits 112684 116114 +3430
+ Misses 5366 2011 -3355
+ Partials 1060 1012 -48 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Use pattern matching for type checks
Refactored code to utilize C# pattern matching with the
iskeyword for type checking and casting, eliminating explicit casts.ElementOrderCodeFixProvider.csto use pattern matching forTypeDeclarationSyntaxandCompilationUnitSyntax.Equalsmethod inUsingCodeFixProvider.TreeTextSpan.csto use pattern matching.DeclarationModifiersHelper.csfor various syntax types, improving readability and maintainability.Closes #3951