Issue 1556: global options to hide reposts and replies

[danguyf]

Issue: #1556

My ultimate goal is to implement the feature requested in #1711 and this issue seemed like a good, simpler use case in order to get familiar with how reposts and replies are identified and displayed so I started here.

[Tlaster]

I'm keeping #1556 in the backlog because I'm still considering the best way to fix the issue.
The easiest fix would be to filter out all replies in dev.dimension.flare.data.datasource.bluesky.HomeTimelineRemoteMediator before saving them to the database, align with other social platforms. However, that would prevent others who want to see the replies in their timeline from doing so. Therefore, this is not the right fix.
This PR updates the TimelinePresenter, meaning the entire application will apply the filter. This will also filter out reposts and replies in other scenarios where the user does not want to apply the filter, such as in profile timeline. This makes future improvements to the user's profile timeline much harder. For example, it would be difficult to add a filter to the user's profile timeline to filter out reposts, replies, and media on the profile page. This filter would not apply globally. I just want to see what the user posts that does not contain reposts, replies, and media.
The closest thing I can think of is making this configuration per home timeline tab (this is also what OpenVibe is doing), which depends on #1388.

[danguyf]

These are all good notes.

I realized the issue with hiding replies on the user page at one point and fixed that but apparently it was not in this branch -- ack! If I port it over and address your other points might this be worth considering?

[Tlaster]

Thanks for the follow up, but I’m afraid this won’t work as-is.
For most users, the expectation is: you may hide reposts/replies on the Home timeline, but once you navigate into secondary/tertiary pages (e.g. Profile, List/Feed), all content should be shown normally. That’s the common behavior across almost all social platforms. So these two options should be limited to Home only.
Regarding #1711: I’m not sure we really need that level of fine-grained control. If we do, it should still be a Home-only setting as well.

[danguyf]

These options are now Home Feed only and stripped of intermediary cruft.

[Tlaster]

Maybe I wasn’t clear earlier.
When I say “Home timeline”, I mean the timeline feeds shown in the different tabs on the Home screen. Those feeds are not necessarily created by HomeTimelinePresenter, since users can customize the Home screen and add different timeline feeds there.
I’m still holding the same view: the request in #1556 somewhat depends on #1388. On the Home screen, each tab’s timeline feed should be able to configure whether that tab’s feed shows reposts or replies (if you’ve used OpenVibe, you’ll know what I mean). This PR doesn’t reflect that behavior yet.

[danguyf]

Okay! This was a good learning experience. I look forward to #1388 and potential future features stemming from it.