Implemented custom dummy names using the element name in the editor #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created DummyBehaviour patch that changes the name of each dummy according to the name of the corresponding element in the editor. ( #26 )
Concerns
I'm fairly certain that this is not the most optimal implementation, as it filters all map elements every time a DummyBehaviour is loaded to get all dummies. If there is a better way to get the names (perhaps using DummyBuilder), please let me know.
Possibilities
In the future there could be a way to choose what cosmetics each dummy is wearing and customize their colors through the editor.