Skip to content

Conversation

@noemifrisina
Copy link
Collaborator

Move in plan to set up parameters for pin tip detection from mx-bluesky

Needed for i19-bluesky#116

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@noemifrisina noemifrisina changed the title I19 116 add plan for pintip params Add a device setup plan to setup the pin tip detection parameters Jan 23, 2026
@noemifrisina noemifrisina marked this pull request as ready for review January 23, 2026 16:56
@noemifrisina noemifrisina requested a review from a team as a code owner January 23, 2026 16:56
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.92%. Comparing base (af74ac0) to head (0204c6c).

Files with missing lines Patch % Lines
...l/plans/device_setup_plans/setup_pin_tip_params.py 0.00% 15 Missing ⚠️
src/dodal/plans/device_setup_plans/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
- Coverage   99.07%   98.92%   -0.15%     
==========================================
  Files         294      297       +3     
  Lines       11207    11249      +42     
==========================================
+ Hits        11103    11128      +25     
- Misses        104      121      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants