Skip to content

Conversation

@EmsArnold
Copy link
Contributor

@EmsArnold EmsArnold commented Jan 21, 2026

Adds a glossary of terms, and style guide.

Closes #876 and #1481.

Instructions to reviewer on how to test:

  1. Do explanations make sense
  2. Are all acronyms/abbreviation/terms included which are currently in use
  3. Is guidance in style guide well reasoned

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (405e437) to head (53687f7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1844   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         289      289           
  Lines       11030    11060   +30     
=======================================
+ Hits        10926    10956   +30     
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmsArnold EmsArnold changed the title Add glossary of terms Add glossary and style guide Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (405e437) to head (c6f90d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1844   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         289      289           
  Lines       11030    11060   +30     
=======================================
+ Hits        10926    10956   +30     
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmsArnold EmsArnold marked this pull request as ready for review January 22, 2026 11:18
@EmsArnold EmsArnold requested a review from a team as a code owner January 22, 2026 11:18
Copy link
Contributor

@oliwenmandiamond oliwenmandiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good and have no objections. Probably need a wider consensus than just myself though

Copy link
Contributor

@Villtord Villtord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it looks great!
I am not a native English speaker so please double check my suggestions :)


## Acronyms

| Acronym | Explanation |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Full name" is more appropriate than "Explanation" here?


## Abbreviations

| Abbreviation | Explanation |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Full name" is more appropriate than "Explanation" here?

| device | Hardware defined via ophyd protocols, although ophyd-async is the standard implementation at Diamond. |
| endstation | An endstation is a collection of devices which can be used together to run experiments, usually distinct from optical devices on a beamline. Beamlines may have one or more endstations which can be used for data collection either in parallel or exclusively. |
| graylog | A log management platform, which all container stdout/stderr logs are sent to at DLS. |
| ISPyB | A managed environment for keeping track of your experiments at some Diamond beamlines. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a native English speaker so please double check my suggestions :)

Suggested change
| ISPyB | A managed environment for keeping track of your experiments at some Diamond beamlines. |
| ISPyB | A managed experimental information service for keeping track of your experiments at some Diamond beamlines. |

| ----------- | -----------|
| blueapi | Lightweight bluesky-as-a-service wrapper application. Also usable as a library. |
| bluesky | Bluesky is a library for experiment control and collection of scientific data and metadata. |
| beamline | A beamline is a collection of devices that can be used together to run experiments, they may be read-only or capable of being set. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| beamline | A beamline is a collection of devices that can be used together to run experiments, they may be read-only or capable of being set. |
| beamline | A beamline is a collection of all devices used to run experiments that make synchrotron light (beam) from a given insertion device produce experimental data, they may be read-only or capable of being set. |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a dodal glossary and style guide

4 participants