-
Notifications
You must be signed in to change notification settings - Fork 12
Add dodal describe that will give the docstrings of what's on the beamline
#1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
=======================================
Coverage 99.05% 99.06%
=======================================
Files 289 289
Lines 11030 11079 +49
=======================================
+ Hits 10926 10975 +49
Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
58a42d8 to
c97bc2e
Compare
|
Would it be good to have a line break between each device doc? e.g something like
or
Feel the output could get cluttered and hard to know where a device doc ends? dodal describe iXX -lb |
tpoliaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's room for improvement in the information the factories offer but this is a useful command as it is so worth merging and updating later if/when we can.
Yes, I agree, I have added. I think having it configurable is overkill though. |
Fixes #1831
Requires #1829 to be merged first
Note for old
ophyddevices this seems to actually try and connect and fail. I think we leave as is given that we should be offophydsoonInstructions to reviewer on how to test:
dodal describe i03Checks for reviewer
dodal connect ${BEAMLINE}