-
Notifications
You must be signed in to change notification settings - Fork 0
Add Embodied Environments documentation #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/source/overview/gym/index.rst
Outdated
| from embodichain.utils import configclass | ||
| @configclass | ||
| class MyTaskEnvCfg(EmbodiedEnvCfg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also explain the parameters of EmbodiedEnvCfg first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's sounds reasonable. Good suggustion!
docs/source/overview/gym/index.rst
Outdated
| * ``replace_assets_from_group``: Swap object models from a folder on reset for visual diversity. | ||
| * ``prepare_extra_attr``: Set up additional object attributes dynamically. | ||
|
|
||
| Observation Manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as event functors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
docs/source/overview/gym/env.md
Outdated
|
|
||
| ### EmbodiedEnvCfg Parameters | ||
|
|
||
| The {class}`envs.EmbodiedEnvCfg` class exposes the following parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseEnvCfg has some important params should be explained as well (eg, sim_steps_per_control)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added the explanation of inherited parameters from BaseEnv.
|
LGTM, just finish the latest comment and we can merge it. |
Description
This PR fills the previously incomplete section (Embodied Environments) of docs. Now it provides explanations of
envs.EmbodiedEnv's core architecture, configuration system, manager systems and action bank.Type of change
Checklist
black .command to format the code base.