Skip to content

Conversation

@yangchen73
Copy link
Collaborator

Description

This PR fills the previously incomplete section (Embodied Environments) of docs. Now it provides explanations of envs.EmbodiedEnv's core architecture, configuration system, manager systems and action bank.

Type of change

  • Documentation update

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation

@yuecideng yuecideng self-requested a review January 14, 2026 13:17
from embodichain.utils import configclass
@configclass
class MyTaskEnvCfg(EmbodiedEnvCfg):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also explain the parameters of EmbodiedEnvCfg first

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's sounds reasonable. Good suggustion!

* ``replace_assets_from_group``: Swap object models from a folder on reset for visual diversity.
* ``prepare_extra_attr``: Set up additional object attributes dynamically.

Observation Manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as event functors

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@yuecideng yuecideng added the docs Improvements or additions to documentation label Jan 14, 2026

### EmbodiedEnvCfg Parameters

The {class}`envs.EmbodiedEnvCfg` class exposes the following parameters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseEnvCfg has some important params should be explained as well (eg, sim_steps_per_control)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added the explanation of inherited parameters from BaseEnv.

@yuecideng
Copy link
Contributor

LGTM, just finish the latest comment and we can merge it.

@yangchen73 yangchen73 merged commit 9a5ce9b into main Jan 16, 2026
5 checks passed
@yangchen73 yangchen73 deleted the yc/add-env-docs branch January 16, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants