Skip to content

Solid angle vis #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
karimsayedre wants to merge 64 commits into
base: hlsl_path_tracer
Choose a base branch
from
Draft

Solid angle vis #232

karimsayedre wants to merge 64 commits into from

Conversation

@karimsayedre
Copy link

@karimsayedre karimsayedre commented Dec 8, 2025

No description provided.

Fletterio and others added 30 commits March 23, 2025 19:29
@Fletterio
Morton code tests
f2ea51d
@Fletterio
Morton codes creating properly
8f4e452
@Fletterio
All tests passing, HLSL compiles fine!
0aedfd9
@Fletterio
Rename example
ea42d5b
@Fletterio
Add tests for AddCarry and SUbBorrow intrinsics
2ba08a4
@Fletterio
Disable intrinsic tests for uSUbBorrow for the time being, start copy…
f00bbf6 
…ing 22_CppCOmpat to run tests
@Fletterio
Added extensive tests for Morton codes
b2d87c3
@Fletterio
Done with tests
c68c336
@Fletterio
Merged master
d906bb2
@Fletterio
Clarifying comment for blocker issue
f05dec4
@Przemog1
Enabled build time shader compilation in example 05
8a8f958
@Przemog1
Fix
f1a3ee5
@Przemog1
Updated source file generation of the 05_streamingandbufferdeviceaddr…
e301db5 
…essappSPIRV project
@Przemog1
Enabled build time shader compilation in multiple examples
f85ae80
@Przemog1
Fixed project creation of multiple examples
22f2a17
@Przemog1
Enabled build time shader compilation in example 10
974d23f
@Przemog1
Enabled build time shader compilation in example 71
eb1e29f
@Przemog1
Replaced vk::RawBufferLoad with vk::PointerBuffer in example 71
e1e8dd6
Merge branch 'master' into mortons
b13fdc7
Reindex mortons example from 12 to 73
08c898d
Global variable of hlsl to use NBL_CONSTEXPR_INLINE_NSPC_SCOPE_VAR
7f8dd73
Add test for operator-
43b8634
Use 1, 1, 1 workgroup dimension
ba6641f
Enable previously failed test because of bug in glm
e830c34
@karimsayedre
New example, copy of 61_UI, updated a lot, visualizer, still not "sol…
f181602 
…id angle", rest should be shader work
@deprilula28
Work on cooperative binary search
4969227
@deprilula28
Patch things for cooperative binary search test
e546428
@deprilula28
Fix test
5886b30
@deprilula28
Remove unecessary leftover file
7950663
@Przemog1
Removed forced -O3 optimization
eb7d4fe
karimsayedre and others added 29 commits December 8, 2025 08:47
@karimsayedre
WIP quick push for shader code
ba068c4
Remove example 73 mortons
2e5642a
@karimsayedre
Fixed main camera aspect ratio, added 27 configurations for cube silh…
91ae865 
…ouette
@karimsayedre
Shader fixes, bast uint16 resolutionf to float
0124cc9
@karimsayedre
Better color for non-silhouette edges
a35eddd
Enable second test set
197b46a
Delete fillSecondTestValues
6692311
Fix morton test
4287ed1
Remove unnecessary code
6a7b003
Add some comment for the reason we have to CTester
f012a1a
Remove dummy code
f415e8c
Fix compiler warning for shader compilation
8f72b9e
Add back second test to first in commented form
3042409
Fix example 28 to use select instead of ternary_op
7011ea0
Fix example 28
02eed2e
@AnastaZIuk
Merge pull request #223 from Devsh-Graphics-Programming/precompiled_s…
1e8372b 
…haders

Precompiled shaders
prefix select with hlsl::
30b4f52
Add nbl prefix to hlsl::select
3e443b1
Merge branch 'master' into mortons
84eb1f7
@devshgraphicsprogramming
Merge pull request #187 from Devsh-Graphics-Programming/mortons
85b7182 
Adds tests for the new Morton Code class
@Fletterio
Patch for semantic clarity, remove usage of hlsl keyword named variable
07d0197
refactor slightly
8a20833
@devshgraphicsprogramming
Merge pull request #235 from Devsh-Graphics-Programming/touch_up_bina…
4ab1de2 
…ry_search

Cooperative Binary Search Unit test
ambiguity of is_same_v patched up
4425ec1
@karimsayedre
A lot more debuggability, and:
1c6458d 
-  Camera movement is disabled correctly
- Hacked ViewManipulate to use for the cube itself
- Added a storage buffer for debugging and getting stuff from GPU to CPU
- Most importantly, disabled skew, used TRS for that
- Random OBB buttons
- Detection of mismatch of silhouette vertices (between slow more correct algo vs fast LUT based algo)
@karimsayedre
better (still not perfect) manual inverse of rotation matrix
2e306fc
@karimsayedre
Fixed faster inverse of rotation matrix, thanks Matt!
12486d4
@karimsayedre
Fast clipping, less branches, also
1961a89 
- More debug data going to imgui
- Little bit of shader code refactoring
- "Revert to last" button to go back to last random transformation of the OBB
- Added getVertexZNeg() and getVertex() preprocessor branches for faster versions
@karimsayedre
Merge branch 'master' into solid-angle-vis
b5d8abc 
# Conflicts:
#	CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Erfan-Ahmadi Erfan-Ahmadi Awaiting requested review from Erfan-Ahmadi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@karimsayedre @Fletterio @Przemog1 @deprilula28 @AnastaZIuk @devshgraphicsprogramming