ex using new debug draw aabb + added draw mesh obb in ex 12 #202

keptsecret · 2025-07-08T08:46:48Z

No description provided.

devshgraphicsprogramming · 2025-07-11T20:33:53Z

very nice, very clean

34_DebugDraw/app_resources/simple_common.hlsl

CMakeLists.txt

devshgraphicsprogramming · 2025-09-17T11:22:49Z

12_MeshLoaders/main.cpp

+				params.assetManager = m_assetMgr;
+				params.transfer = getTransferUpQueue();
+				params.drawMode = ext::debug_draw::DrawAABB::ADM_DRAW_BATCH;
+				params.batchPipelineLayout = ext::debug_draw::DrawAABB::createDefaultPipelineLayout(m_device.get());


I'm pretty sure the push constant range for the layout can be wrong here by accident see review of the main nabla PR

please Address

AnastaZIuk · 2025-12-19T13:11:24Z

34_DebugDraw/pipeline.groovy

@@ -0,0 +1,50 @@
+import org.DevshGraphicsProgramming.Agent


remove the file please, we have now actions based CI

AnastaZIuk · 2025-12-19T13:12:01Z

34_DebugDraw/config.json.template

@@ -0,0 +1,28 @@
+{


as well as https://github.com/Devsh-Graphics-Programming/Nabla-Examples-and-Tests/pull/202/files#r2635058708

devshgraphicsprogramming · 2025-12-19T20:42:49Z

34_DebugDraw/main.cpp

+	std::array<float32_t3, 24> getVerticesFromAABB(core::aabbox3d<float>& aabb)
+	{
+		const auto& pMin = aabb.MinEdge;
+		const auto& pMax = aabb.MaxEdge;
+
+		std::array<float32_t3, 24> vertices;
+		vertices[0] = float32_t3(pMin.X, pMin.Y, pMin.Z);
+		vertices[1] = float32_t3(pMax.X, pMin.Y, pMin.Z);
+		vertices[2] = float32_t3(pMin.X, pMin.Y, pMin.Z);
+		vertices[3] = float32_t3(pMin.X, pMin.Y, pMax.Z);
+
+		vertices[4] = float32_t3(pMax.X, pMin.Y, pMax.Z);
+		vertices[5] = float32_t3(pMax.X, pMin.Y, pMin.Z);
+		vertices[6] = float32_t3(pMax.X, pMin.Y, pMax.Z);
+		vertices[7] = float32_t3(pMin.X, pMin.Y, pMax.Z);
+
+		vertices[8] = float32_t3(pMin.X, pMax.Y, pMin.Z);
+		vertices[9] = float32_t3(pMax.X, pMax.Y, pMin.Z);
+		vertices[10] = float32_t3(pMin.X, pMax.Y, pMin.Z);
+		vertices[11] = float32_t3(pMin.X, pMax.Y, pMax.Z);
+
+		vertices[12] = float32_t3(pMax.X, pMax.Y, pMax.Z);
+		vertices[13] = float32_t3(pMax.X, pMax.Y, pMin.Z);
+		vertices[14] = float32_t3(pMax.X, pMax.Y, pMax.Z);
+		vertices[15] = float32_t3(pMin.X, pMax.Y, pMax.Z);
+
+		vertices[16] = float32_t3(pMin.X, pMin.Y, pMin.Z);
+		vertices[17] = float32_t3(pMin.X, pMax.Y, pMin.Z);
+		vertices[18] = float32_t3(pMax.X, pMin.Y, pMin.Z);
+		vertices[19] = float32_t3(pMax.X, pMax.Y, pMin.Z);
+
+		vertices[20] = float32_t3(pMin.X, pMin.Y, pMax.Z);
+		vertices[21] = float32_t3(pMin.X, pMax.Y, pMax.Z);
+		vertices[22] = float32_t3(pMax.X, pMin.Y, pMax.Z);
+		vertices[23] = float32_t3(pMax.X, pMax.Y, pMax.Z);
+
+		return vertices;
+	}


unused function

devshgraphicsprogramming · 2025-12-19T20:43:13Z

34_DebugDraw/main.cpp

+	smart_refctd_ptr<IGPUGraphicsPipeline> m_pipeline;
+	smart_refctd_ptr<IGPUGraphicsPipeline> m_streamingPipeline;


unused variables

devshgraphicsprogramming · 2025-12-19T20:43:24Z

34_DebugDraw/main.cpp

+    InputSystem::ChannelReader<IMouseEventChannel> mouse;
+    InputSystem::ChannelReader<IKeyboardEventChannel> keyboard;
+
+	core::smart_refctd_ptr<IDescriptorPool> m_descriptorSetPool;


unused variable

devshgraphicsprogramming · 2025-12-19T20:43:57Z

34_DebugDraw/main.cpp

+
+	uint16_t gcIndex = {}; // note: this is dirty however since I assume only single object in scene I can leave it now, when this example is upgraded to support multiple objects this needs to be changed
+
+	float fov = 60.f, zNear = 0.1f, zFar = 10000.f, moveSpeed = 1.f, rotateSpeed = 1.f;


you probably want them constexpr near where they are getting used instead of being members

devshgraphicsprogramming · 2025-12-19T20:44:04Z

34_DebugDraw/main.cpp

+	Camera camera;
+	video::CDumbPresentationOracle oracle;
+
+	uint16_t gcIndex = {}; // note: this is dirty however since I assume only single object in scene I can leave it now, when this example is upgraded to support multiple objects this needs to be changed


unused variable

devshgraphicsprogramming · 2025-12-19T20:44:30Z

34_DebugDraw/main.cpp

+	hlsl::shapes::AABB<3, float> testAABB = hlsl::shapes::AABB<3, float>{ { -5, -5, -5 }, { 10, 10, -10 } };
+
+	using streaming_buffer_t = video::StreamingTransientDataBufferST<core::allocator<uint8_t>>;
+	smart_refctd_ptr<streaming_buffer_t> streamingBuffer;


unused variable

keptsecret added 22 commits June 30, 2025 17:04

initial skeleton for debug draw ex

88002c3

use camera with lines

3df145b

merge mesh_loaders

ac56991

fixes from mesh_loader merge

6d5a495

removed unused files

c5dae98

draw aabb from push constant

17b53a8

move single aabb stuff into CDrawAABB

a62cbed

Merge branch 'master' into new_debug_draw

00185f2

default pipeline creation func

5fa8874

got streaming buffer working and drawing

704a0fb

draw with instances

a81e62f

minor bug fix in creating instances

da63edf

Merge branch 'master' into new_debug_draw

7469300

move handling instances to CDrawAABB

9ae72f5

moved most important streaming stuff to CDrawAABB

7a22eef

moved most core func to CDrawAABB

f18bf38

handle streaming buffer overflow

09ef478

update example scene

aee85b4

use debug draw extension

738269e

Merge branch 'master' into new_debug_draw

c698bb7

removed old mesh loaders

61b1c00

add debug aabb draws around mesh

4f1fabd

keptsecret changed the title ~~ex using new debug draw aabb~~ ex using new debug draw aabb + added draw mesh obb in ex 12 Jul 9, 2025

merge master, fix conflicts

b31cfba

devshgraphicsprogramming reviewed Aug 18, 2025

View reviewed changes

34_DebugDraw/app_resources/simple_common.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed Aug 18, 2025

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

keptsecret added 3 commits August 18, 2025 16:52

refactor debug_draw namespace

bfd286e

refactor remove usage of legacy matrices

8518c2b

refactor examples with latest DrawAabb changes

323c782

keptsecret added 5 commits August 20, 2025 16:13

use draw modes

f75dc21

Merge branch 'master' into new_debug_draw

83a71a8

merge master, fix conflicts

347933d

don't EXCLUDE_ALL new example

3b1016e

Merge branch 'master' into new_debug_draw

36171d7

devshgraphicsprogramming reviewed Sep 17, 2025

View reviewed changes

keptsecret added 6 commits November 27, 2025 14:36

Merge branch 'master' into new_debug_draw

c297eaa

refactor link debug_draw lib

292cbbf

refactor link debug_draw lib in ex 12

8af6682

refactor draw aabb usage

cc341e7

Merge branch 'master' into new_debug_draw

d3ac4cc

removed commented out bits

e4366b1

devshgraphicsprogramming requested a review from AnastaZIuk December 19, 2025 12:55

AnastaZIuk reviewed Dec 19, 2025

View reviewed changes

devshgraphicsprogramming reviewed Dec 19, 2025

View reviewed changes

		smart_refctd_ptr<IGPUGraphicsPipeline> m_pipeline;
		smart_refctd_ptr<IGPUGraphicsPipeline> m_streamingPipeline;


		uint16_t gcIndex = {}; // note: this is dirty however since I assume only single object in scene I can leave it now, when this example is upgraded to support multiple objects this needs to be changed

		float fov = 60.f, zNear = 0.1f, zFar = 10000.f, moveSpeed = 1.f, rotateSpeed = 1.f;

ex using new debug draw aabb + added draw mesh obb in ex 12 #202

Are you sure you want to change the base?

ex using new debug draw aabb + added draw mesh obb in ex 12 #202

Uh oh!

Conversation

keptsecret commented Jul 8, 2025

Uh oh!

devshgraphicsprogramming commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants