Skip to content

Properly configure the ARM64 Agent installer as an ARM64 package#1673

Open
thenextman wants to merge 3 commits intomasterfrom
agent-package-arm64-package
Open

Properly configure the ARM64 Agent installer as an ARM64 package#1673
thenextman wants to merge 3 commits intomasterfrom
agent-package-arm64-package

Conversation

@thenextman
Copy link
Member

@thenextman thenextman commented Feb 12, 2026

We need to properly mark the ARM64 installer as an ARM64 package, or else it can be installed on an x64 system (leading to a broken install).

➕ some minor installer housekeeping

@thenextman thenextman requested a review from Copilot February 12, 2026 15:30
@github-actions
Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows MSI packaging flow to correctly set the WixSharp installer platform (x64 vs arm64) based on build/CI inputs, supporting ARM64 agent installer generation.

Changes:

  • Derive MSI platform (x64/arm64) from a DAGENT_PLATFORM environment variable and wire it into the WixSharp project.
  • Update CI/packaging scripts to pass architecture into the MSI build via DAGENT_PLATFORM.
  • Minor refactors/updates: use named parameters for feature definitions, rename UI field usage, bump NuGet versions, and ignore downloaded binaries.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
package/AgentWindowsManaged/Resources/Features.cs Uses named arguments for Feature construction for clarity.
package/AgentWindowsManaged/Program.cs Adds platform resolution from env var and applies it to WixSharp project platform; adjusts default artifact paths.
package/AgentWindowsManaged/Dialogs/FeaturesDialog.cs Renames FeatureItem UI backing field usage from View to ViewModel.
package/AgentWindowsManaged/DevolutionsAgent.csproj Updates NuGet package versions.
ci/tlk.ps1 Exports DAGENT_PLATFORM from the recipe target architecture.
ci/package-agent-windows.ps1 Adds mandatory -Architecture parameter and exports DAGENT_PLATFORM for the MSI build.
.gitignore Ignores downloaded tun2socks.exe and wintun.dll.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thenextman thenextman force-pushed the agent-package-arm64-package branch from 71ab6d8 to 543a6f3 Compare February 12, 2026 15:43
@thenextman thenextman marked this pull request as ready for review February 12, 2026 16:33
@thenextman thenextman enabled auto-merge (rebase) February 12, 2026 16:33
@thenextman thenextman requested a review from a team February 12, 2026 16:33
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants