T1317673 - PivotGrid - Fix rowsArea layout when virtualScrolling is enabled #32340
+59
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pivot grid area rendering logic to improve row layout (especially in the rows area) when virtual scrolling is enabled, and adds stronger typing around DOM access.
Changes:
- Refactors
_getRowElementand_getRowHeightto be more type-safe and to use direct DOM APIs for row lookup and measurement. - Simplifies
_renderTableContentto use block-scoped variables and clearer style application, while preserving existing customization hooks. - Reimplements
getColumnsWidthwith typed arrays and cleaner span-handling logic for computing effective column widths.
packages/devextreme/js/__internal/grids/pivot_grid/area_item/m_area_item.ts
Outdated
Show resolved
Hide resolved
Tucchhaa
force-pushed
the
pivorgrid_virtual_scrolling_26_1
branch
from
bb87e84 to
0c21c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.