-
Notifications
You must be signed in to change notification settings - Fork 665
Scheduler - Appointment Form - Refactor POM #32339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 26_1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors the Page Object Model (POM) for the Scheduler Appointment Form test infrastructure, improving code quality and maintainability by simplifying interfaces and making them more consistent.
Changes:
- Refactored POM classes to use property getters instead of method calls (e.g.,
getSaveButton()→saveButton) - Renamed
formtodxFormfor better clarity about the DevExtreme Form instance - Removed numerous unused helper methods from both TestCafe and Jest POMs, simplifying the codebase
- Updated all test files to use the new simplified POM interface
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/testcafe-models/scheduler/appointment/popup.ts |
Removed unused selectors and methods; renamed openRecurrenceForm to selectRepeatValue and openRecurrenceSettings to clickRecurrenceSettingsButton; renamed listOption to listItem |
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts |
Major refactoring: added queryRequiredElement helper; converted method-based getters to property getters for buttons and elements; renamed form to dxForm; removed many unused utility methods |
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts |
Updated ~100+ test usages to use new POM interface (.form → .dxForm, method calls → property accesses); removed some await nextTick statements |
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/recurrence-form.visual.ts |
Updated method calls to use new POM method names |
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/form.functional.ts |
Updated method calls to use new POM method names |
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
No description provided.