Skip to content

Conversation

@Tucchhaa
Copy link
Contributor

No description provided.

@Tucchhaa Tucchhaa requested a review from a team as a code owner January 29, 2026 07:01
Copilot AI review requested due to automatic review settings January 29, 2026 07:01
@Tucchhaa Tucchhaa self-assigned this Jan 29, 2026
@Tucchhaa Tucchhaa added the 26_1 label Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the Page Object Model (POM) for the Scheduler Appointment Form test infrastructure, improving code quality and maintainability by simplifying interfaces and making them more consistent.

Changes:

  • Refactored POM classes to use property getters instead of method calls (e.g., getSaveButton()saveButton)
  • Renamed form to dxForm for better clarity about the DevExtreme Form instance
  • Removed numerous unused helper methods from both TestCafe and Jest POMs, simplifying the codebase
  • Updated all test files to use the new simplified POM interface

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/testcafe-models/scheduler/appointment/popup.ts Removed unused selectors and methods; renamed openRecurrenceForm to selectRepeatValue and openRecurrenceSettings to clickRecurrenceSettingsButton; renamed listOption to listItem
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts Major refactoring: added queryRequiredElement helper; converted method-based getters to property getters for buttons and elements; renamed form to dxForm; removed many unused utility methods
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts Updated ~100+ test usages to use new POM interface (.form.dxForm, method calls → property accesses); removed some await nextTick statements
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/recurrence-form.visual.ts Updated method calls to use new POM method names
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/form.functional.ts Updated method calls to use new POM method names

Copilot AI review requested due to automatic review settings January 29, 2026 07:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant