Merged
Conversation
…ment (tensorflow#7055) ## Motivation for features / changes The CI/CD pipeline was failing due to a combination of infrastructure constraints and missing dependencies in the GitHub Actions environment. Specifically, the failures were caused by: Resource Exhaustion (OOM): Several profile plugin tests were crashing the container when running in parallel. Missing System Dependencies: Chrome Headless (used for Karma/Frontend tests) failed to launch due to missing shared libraries (libgbm, libxss, etc.) in the runner environment. Network Configuration: The testSpecifiedHost test was failing because the CI environment could not bind to the IPv6 address ::1, causing an unhandled OSError. This PR fixes these issues to restore a green build state and ensure reliability across different runner environments. ## Technical description of changes CI Workflow (.github/workflows/ci.yml): Added a step to install libgbm-dev, libxss1, and libasound2. These are required by modern versions of Chrome Headless to render correctly during frontend tests. Bazel Configuration (BUILD files): Added tags = ["exclusive"] to memory-intensive tests in //tensorboard/plugins/profile/... (pod_viewer_utils_test, pod_viewer_common_test, and memory_usage_test). This prevents them from running in parallel with other tests, avoiding container OOM crashes. Fixed formatting (linting) issues to comply with buildifier. Python Tests (tensorboard/program_test.py): Updated testSpecifiedHost to catch OSError and SystemExit. This allows the test to pass if Werkzeug fails to bind to a specific interface (like IPv6) due to environment restrictions, provided that IPv4 binding works or is handled gracefully. Applied black formatting to satisfy the linter. ## Screenshots of UI changes (or N/A) ## Detailed steps to verify changes work correctly (as executed by you) ## Alternate designs / implementations considered (or N/A)
…orflow#7055) Pull upstream commit 3ad0c35 which resolves CI test failures: - Add Chrome dependencies (libgbm-dev, libxss1, libasound2) to CI workflow - Add 'exclusive' tag to manager_test and program_test BUILD targets - Fix manager_test expected debug call count (2 -> 3) - Broaden exception handling in program_test for IPv6 bind failures Conflicts resolved in tensorbored/BUILD: - Kept fork's tensorbored/defs paths with upstream's load reordering - Accepted upstream's 'exclusive' tag for manager_test with fork's visibility path Co-authored-by: Samuel <samuel@knutsen.co>
|
Cursor Agent can help with this pull request. Just |
The upstream commit changed the expected debug call count from 2 to 3, but this is only correct when running as root (where os.chmod 0o000 doesn't prevent reading). On our ubuntu-22.04 GitHub-hosted runners (non-root), the unreadable file correctly triggers EACCES which is silently handled via 'continue' in manager.get_all(), producing only 2 debug log calls. Co-authored-by: Samuel <samuel@knutsen.co>
Preview Deployment
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This PR merges the latest upstream changes from
tensorflow/tensorboardto keep our fork up-to-date. Specifically, it incorporates commit3ad0c359which resolves CI test failures related to the environment.Technical description of changes
3ad0c359("Resolve test failures for CI workflows for TensorBoard in new environment (Resolve test failures for CI workflows for TensorBoard in new environment tensorflow/tensorboard#7055)").tensorbored/BUILD:loadstatements to match upstream's preferred order, while preservingtensorboredspecific paths.manager_testtarget to include the"exclusive"tag and"large"size from upstream, while maintaining the fork'stensorboredvisibility path..github/workflows/ci.yml: Added Chrome dependencies for frontend tests.tensorbored/manager_test.py: Updated an expected debug call count.tensorbored/program_test.py: Broadened exception handling intestSpecifiedHost.Screenshots of UI changes (or N/A)
N/A
Detailed steps to verify changes work correctly (as executed by you)
3ad0c359.tensorbored/BUILDconflict resolution:tensorboredpaths maintained.manager_testtarget updated with"exclusive"tag and"large"size,tensorboredvisibility path maintained..github/workflows/ci.yml,tensorbored/manager_test.py,tensorbored/program_test.py) correctly integrated upstream changes while respecting fork'stensorboredpaths.Alternate designs / implementations considered (or N/A)
N/A