Open
Conversation
Utkarsh-Singhal-26
force-pushed
the
fixes/webgl-cleanup
branch
from
bd92ec8 to
8346e53
Compare
Comment on lines
+259
to
+282
|
|
||
| useEffect(() => { | ||
| if (materialRef.current) materialRef.current.uniforms.u_shapeSize.value = shapeSize; | ||
| }, [shapeSize]); | ||
|
|
||
| useEffect(() => { | ||
| if (materialRef.current) materialRef.current.uniforms.u_roundness.value = roundness; | ||
| }, [roundness]); | ||
|
|
||
| useEffect(() => { | ||
| if (materialRef.current) materialRef.current.uniforms.u_borderSize.value = borderSize; | ||
| }, [borderSize]); | ||
|
|
||
| useEffect(() => { | ||
| if (materialRef.current) materialRef.current.uniforms.u_circleSize.value = circleSize; | ||
| }, [circleSize]); | ||
|
|
||
| useEffect(() => { | ||
| if (materialRef.current) materialRef.current.uniforms.u_circleEdge.value = circleEdge; | ||
| }, [circleEdge]); | ||
|
|
||
| useEffect(() => { | ||
| if (materialRef.current) materialRef.current.uniforms.u_pixelRatio.value = pixelRatioProp; | ||
| }, [pixelRatioProp]); |
Contributor
There was a problem hiding this comment.
Why is splitting the changes across several individual useEffects better than before?
Contributor
There was a problem hiding this comment.
I am not an official reviewer, but I took a look, and those changes look great. There is only one thing that I do not understand the benefit of, at ShapeBlur components
Contributor
Author
There was a problem hiding this comment.
Splitting the changes across multiple useEffect is better because it avoids rebuilding the entire Three.js scene every time a prop changes.
In the original version, any change to shapeSize, roundness, etc. triggers the main effect, which:
- Disposes the renderer
- Removes the canvas
- Recreates the scene, camera, material, listeners, animation loop
That’s expensive and unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #875
Components Affected: