Adding Logging for JMS `ITERATION` Scope by mhlidd · Pull Request #10632 · DataDog/dd-trace-java

mhlidd · 2026-02-18T21:37:06Z

What Does This Do

Adding logging for JMS iteration scope to allow logging of hanging unfinished spans.

Motivation

Escalation Rotation

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

ygree · 2026-02-18T22:07:08Z

dd-trace-core/src/main/java/datadog/trace/core/scopemanager/ContinuableScopeManager.java

Instead of the source, it will output the scope and context. Did you mean to write "top.source()" instead?

ygree · 2026-02-18T22:18:54Z

dd-trace-core/src/main/java/datadog/trace/core/scopemanager/ContinuableScopeManager.java


    // close any immediately previous iteration scope
    final ContinuableScope top = scopeStack.top;
-    if (top != null && top.source() == ITERATION) {


To minimize the change scope, you could keep this as is and add else if (top!=null) instead.

pr-commenter · 2026-02-18T22:25:03Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/add_jms_logging
git_commit_date	1771441202	1771457508
git_commit_sha	`2fa3c0c`	`a1992da`
release_version	1.60.0-SNAPSHOT~2fa3c0c243	1.60.0-SNAPSHOT~a1992da809

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1771459286	1771459286
ci_job_id	1437814898	1437814898
ci_pipeline_id	97425580	97425580
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-2hud67az 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-2hud67az 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065117
Total [baseline] (10.897 s) : 0, 10896991
Agent [candidate] (1.065 s) : 0, 1064742
Total [candidate] (10.887 s) : 0, 10886508
section appsec
Agent [baseline] (1.237 s) : 0, 1237445
Total [baseline] (10.979 s) : 0, 10978534
Agent [candidate] (1.237 s) : 0, 1236918
Total [candidate] (10.974 s) : 0, 10973609
section iast
Agent [baseline] (1.246 s) : 0, 1245625
Total [baseline] (11.259 s) : 0, 11259075
Agent [candidate] (1.232 s) : 0, 1231722
Total [candidate] (11.122 s) : 0, 11122150
section profiling
Agent [baseline] (1.189 s) : 0, 1188583
Total [baseline] (10.889 s) : 0, 10889325
Agent [candidate] (1.193 s) : 0, 1192999
Total [candidate] (10.955 s) : 0, 10955434

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	appsec	1.237 s	172.328 ms (16.2%)
Agent	iast	1.246 s	180.508 ms (16.9%)
Agent	profiling	1.189 s	123.466 ms (11.6%)
Total	tracing	10.897 s	-
Total	appsec	10.979 s	81.543 ms (0.7%)
Total	iast	11.259 s	362.085 ms (3.3%)
Total	profiling	10.889 s	-7.665 ms (-0.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	appsec	1.237 s	172.177 ms (16.2%)
Agent	iast	1.232 s	166.98 ms (15.7%)
Agent	profiling	1.193 s	128.257 ms (12.0%)
Total	tracing	10.887 s	-
Total	appsec	10.974 s	87.1 ms (0.8%)
Total	iast	11.122 s	235.642 ms (2.2%)
Total	profiling	10.955 s	68.925 ms (0.6%)

gantt
    title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (627.662 ms) : 0, 627662
BytebuddyAgent [candidate] (627.315 ms) : 0, 627315
AgentMeter [baseline] (29.177 ms) : 0, 29177
AgentMeter [candidate] (29.075 ms) : 0, 29075
GlobalTracer [baseline] (257.352 ms) : 0, 257352
GlobalTracer [candidate] (257.281 ms) : 0, 257281
AppSec [baseline] (33.069 ms) : 0, 33069
AppSec [candidate] (32.87 ms) : 0, 32870
Debugger [baseline] (65.502 ms) : 0, 65502
Debugger [candidate] (62.615 ms) : 0, 62615
Remote Config [baseline] (620.32 µs) : 0, 620
Remote Config [candidate] (610.625 µs) : 0, 611
Telemetry [baseline] (9.919 ms) : 0, 9919
Telemetry [candidate] (10.769 ms) : 0, 10769
Flare Poller [baseline] (4.562 ms) : 0, 4562
Flare Poller [candidate] (6.913 ms) : 0, 6913
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (656.442 ms) : 0, 656442
BytebuddyAgent [candidate] (656.887 ms) : 0, 656887
AgentMeter [baseline] (11.924 ms) : 0, 11924
AgentMeter [candidate] (11.934 ms) : 0, 11934
GlobalTracer [baseline] (257.654 ms) : 0, 257654
GlobalTracer [candidate] (257.391 ms) : 0, 257391
AppSec [baseline] (167.926 ms) : 0, 167926
AppSec [candidate] (167.8 ms) : 0, 167800
Debugger [baseline] (67.079 ms) : 0, 67079
Debugger [candidate] (66.491 ms) : 0, 66491
Remote Config [baseline] (644.358 µs) : 0, 644
Remote Config [candidate] (657.471 µs) : 0, 657
Telemetry [baseline] (9.517 ms) : 0, 9517
Telemetry [candidate] (9.404 ms) : 0, 9404
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.619 ms) : 0, 3619
IAST [baseline] (25.3 ms) : 0, 25300
IAST [candidate] (25.493 ms) : 0, 25493
section iast
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (807.334 ms) : 0, 807334
BytebuddyAgent [candidate] (794.702 ms) : 0, 794702
AgentMeter [baseline] (11.78 ms) : 0, 11780
AgentMeter [candidate] (11.321 ms) : 0, 11321
GlobalTracer [baseline] (248.815 ms) : 0, 248815
GlobalTracer [candidate] (247.965 ms) : 0, 247965
AppSec [baseline] (32.631 ms) : 0, 32631
AppSec [candidate] (34.123 ms) : 0, 34123
Debugger [baseline] (67.708 ms) : 0, 67708
Debugger [candidate] (66.65 ms) : 0, 66650
Remote Config [baseline] (539.779 µs) : 0, 540
Remote Config [candidate] (547.959 µs) : 0, 548
Telemetry [baseline] (8.674 ms) : 0, 8674
Telemetry [candidate] (8.654 ms) : 0, 8654
Flare Poller [baseline] (3.464 ms) : 0, 3464
Flare Poller [candidate] (3.42 ms) : 0, 3420
IAST [baseline] (27.14 ms) : 0, 27140
IAST [candidate] (27.111 ms) : 0, 27111
section profiling
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (680.739 ms) : 0, 680739
BytebuddyAgent [candidate] (683.676 ms) : 0, 683676
AgentMeter [baseline] (8.522 ms) : 0, 8522
AgentMeter [candidate] (8.595 ms) : 0, 8595
GlobalTracer [baseline] (215.654 ms) : 0, 215654
GlobalTracer [candidate] (216.369 ms) : 0, 216369
AppSec [baseline] (32.279 ms) : 0, 32279
AppSec [candidate] (32.73 ms) : 0, 32730
Debugger [baseline] (67.122 ms) : 0, 67122
Debugger [candidate] (67.243 ms) : 0, 67243
Remote Config [baseline] (630.292 µs) : 0, 630
Remote Config [candidate] (635.496 µs) : 0, 635
Telemetry [baseline] (8.992 ms) : 0, 8992
Telemetry [candidate] (9.047 ms) : 0, 9047
Flare Poller [baseline] (3.73 ms) : 0, 3730
Flare Poller [candidate] (3.766 ms) : 0, 3766
ProfilingAgent [baseline] (99.08 ms) : 0, 99080
ProfilingAgent [candidate] (99.12 ms) : 0, 99120
Profiling [baseline] (99.652 ms) : 0, 99652
Profiling [candidate] (99.699 ms) : 0, 99699

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062333
Total [baseline] (8.714 s) : 0, 8713600
Agent [candidate] (1.064 s) : 0, 1064206
Total [candidate] (8.738 s) : 0, 8737633
section iast
Agent [baseline] (1.231 s) : 0, 1231195
Total [baseline] (9.371 s) : 0, 9370698
Agent [candidate] (1.228 s) : 0, 1228168
Total [candidate] (9.371 s) : 0, 9371134

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.231 s	168.862 ms (15.9%)
Total	tracing	8.714 s	-
Total	iast	9.371 s	657.098 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	iast	1.228 s	163.962 ms (15.4%)
Total	tracing	8.738 s	-
Total	iast	9.371 s	633.5 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (625.922 ms) : 0, 625922
BytebuddyAgent [candidate] (626.658 ms) : 0, 626658
AgentMeter [baseline] (29.057 ms) : 0, 29057
AgentMeter [candidate] (29.088 ms) : 0, 29088
GlobalTracer [baseline] (256.8 ms) : 0, 256800
GlobalTracer [candidate] (257.376 ms) : 0, 257376
AppSec [baseline] (32.952 ms) : 0, 32952
AppSec [candidate] (32.887 ms) : 0, 32887
Debugger [baseline] (62.848 ms) : 0, 62848
Debugger [candidate] (62.85 ms) : 0, 62850
Remote Config [baseline] (625.467 µs) : 0, 625
Remote Config [candidate] (606.919 µs) : 0, 607
Telemetry [baseline] (10.616 ms) : 0, 10616
Telemetry [candidate] (11.389 ms) : 0, 11389
Flare Poller [baseline] (6.222 ms) : 0, 6222
Flare Poller [candidate] (6.1 ms) : 0, 6100
section iast
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (796.389 ms) : 0, 796389
BytebuddyAgent [candidate] (792.927 ms) : 0, 792927
AgentMeter [baseline] (11.316 ms) : 0, 11316
AgentMeter [candidate] (11.334 ms) : 0, 11334
GlobalTracer [baseline] (247.12 ms) : 0, 247120
GlobalTracer [candidate] (247.381 ms) : 0, 247381
AppSec [baseline] (31.333 ms) : 0, 31333
AppSec [candidate] (33.125 ms) : 0, 33125
Debugger [baseline] (68.13 ms) : 0, 68130
Debugger [candidate] (66.583 ms) : 0, 66583
Remote Config [baseline] (596.255 µs) : 0, 596
Remote Config [candidate] (524.069 µs) : 0, 524
Telemetry [baseline] (8.611 ms) : 0, 8611
Telemetry [candidate] (8.663 ms) : 0, 8663
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.45 ms) : 0, 3450
IAST [baseline] (27.002 ms) : 0, 27002
IAST [candidate] (26.967 ms) : 0, 26967

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/add_jms_logging
git_commit_date	1771441202	1771457508
git_commit_sha	`2fa3c0c`	`a1992da`
release_version	1.60.0-SNAPSHOT~2fa3c0c243	1.60.0-SNAPSHOT~a1992da809

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1771459877	1771459877
ci_job_id	1437814899	1437814899
ci_pipeline_id	97425580	97425580
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-vhwpqp6q 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-vhwpqp6q 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	better [-409.278µs; -172.011µs] or [-7.828%; -3.290%]	better [-1027.425µs; -344.209µs] or [-8.208%; -2.750%]	unstable [-44.703op/s; +118.203op/s] or [-5.687%; +15.039%]	4.938ms	11.832ms	822.750op/s	5.228ms	12.518ms	786.000op/s
scenario:load:petclinic:iast:high_load	better [-1.792ms; -0.812ms] or [-9.651%; -4.374%]	unsure [-1.908ms; -0.282ms] or [-6.382%; -0.942%]	unstable [-11.066op/s; +44.004op/s] or [-4.471%; +17.777%]	17.261ms	28.797ms	264.000op/s	18.563ms	29.891ms	247.531op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.192 ms) : 1180, 1204
.   : milestone, 1192,
iast (3.221 ms) : 3173, 3269
.   : milestone, 3221,
iast_FULL (5.881 ms) : 5821, 5941
.   : milestone, 5881,
iast_GLOBAL (3.389 ms) : 3343, 3436
.   : milestone, 3389,
profiling (2.045 ms) : 2025, 2064
.   : milestone, 2045,
tracing (1.726 ms) : 1713, 1739
.   : milestone, 1726,
section candidate
no_agent (1.193 ms) : 1181, 1205
.   : milestone, 1193,
iast (3.172 ms) : 3133, 3211
.   : milestone, 3172,
iast_FULL (5.618 ms) : 5563, 5673
.   : milestone, 5618,
iast_GLOBAL (3.428 ms) : 3381, 3474
.   : milestone, 3428,
profiling (2.085 ms) : 2067, 2103
.   : milestone, 2085,
tracing (1.751 ms) : 1737, 1765
.   : milestone, 1751,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.192 ms [1.18 ms, 1.204 ms]	-
iast	3.221 ms [3.173 ms, 3.269 ms]	2.029 ms (170.2%)
iast_FULL	5.881 ms [5.821 ms, 5.941 ms]	4.689 ms (393.4%)
iast_GLOBAL	3.389 ms [3.343 ms, 3.436 ms]	2.197 ms (184.3%)
profiling	2.045 ms [2.025 ms, 2.064 ms]	852.466 µs (71.5%)
tracing	1.726 ms [1.713 ms, 1.739 ms]	534.104 µs (44.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.193 ms [1.181 ms, 1.205 ms]	-
iast	3.172 ms [3.133 ms, 3.211 ms]	1.979 ms (165.9%)
iast_FULL	5.618 ms [5.563 ms, 5.673 ms]	4.425 ms (370.9%)
iast_GLOBAL	3.428 ms [3.381 ms, 3.474 ms]	2.235 ms (187.4%)
profiling	2.085 ms [2.067 ms, 2.103 ms]	892.056 µs (74.8%)
tracing	1.751 ms [1.737 ms, 1.765 ms]	558.329 µs (46.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.97 ms) : 17787, 18154
.   : milestone, 17970,
appsec (18.432 ms) : 18248, 18617
.   : milestone, 18432,
code_origins (17.837 ms) : 17661, 18014
.   : milestone, 17837,
iast (18.857 ms) : 18666, 19048
.   : milestone, 18857,
profiling (18.511 ms) : 18327, 18695
.   : milestone, 18511,
tracing (17.715 ms) : 17539, 17890
.   : milestone, 17715,
section candidate
no_agent (18.072 ms) : 17888, 18256
.   : milestone, 18072,
appsec (18.482 ms) : 18295, 18669
.   : milestone, 18482,
code_origins (17.62 ms) : 17445, 17795
.   : milestone, 17620,
iast (17.674 ms) : 17496, 17851
.   : milestone, 17674,
profiling (18.604 ms) : 18416, 18791
.   : milestone, 18604,
tracing (17.654 ms) : 17476, 17832
.   : milestone, 17654,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.97 ms [17.787 ms, 18.154 ms]	-
appsec	18.432 ms [18.248 ms, 18.617 ms]	461.999 µs (2.6%)
code_origins	17.837 ms [17.661 ms, 18.014 ms]	-132.96 µs (-0.7%)
iast	18.857 ms [18.666 ms, 19.048 ms]	887.015 µs (4.9%)
profiling	18.511 ms [18.327 ms, 18.695 ms]	540.871 µs (3.0%)
tracing	17.715 ms [17.539 ms, 17.89 ms]	-255.478 µs (-1.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.072 ms [17.888 ms, 18.256 ms]	-
appsec	18.482 ms [18.295 ms, 18.669 ms]	409.995 µs (2.3%)
code_origins	17.62 ms [17.445 ms, 17.795 ms]	-451.972 µs (-2.5%)
iast	17.674 ms [17.496 ms, 17.851 ms]	-398.233 µs (-2.2%)
profiling	18.604 ms [18.416 ms, 18.791 ms]	531.572 µs (2.9%)
tracing	17.654 ms [17.476 ms, 17.832 ms]	-417.786 µs (-2.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/add_jms_logging
git_commit_date	1771441202	1771457508
git_commit_sha	`2fa3c0c`	`a1992da`
release_version	1.60.0-SNAPSHOT~2fa3c0c243	1.60.0-SNAPSHOT~a1992da809

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1771459564	1771459564
ci_job_id	1437814900	1437814900
ci_pipeline_id	97425580	97425580
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-96s69034 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-96s69034 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (3.812 ms) : 3592, 4033
.   : milestone, 3812,
iast (2.258 ms) : 2189, 2328
.   : milestone, 2258,
iast_GLOBAL (2.305 ms) : 2235, 2375
.   : milestone, 2305,
profiling (2.091 ms) : 2036, 2146
.   : milestone, 2091,
tracing (2.063 ms) : 2009, 2117
.   : milestone, 2063,
section candidate
no_agent (1.478 ms) : 1466, 1490
.   : milestone, 1478,
appsec (3.794 ms) : 3571, 4018
.   : milestone, 3794,
iast (2.265 ms) : 2196, 2335
.   : milestone, 2265,
iast_GLOBAL (2.303 ms) : 2234, 2373
.   : milestone, 2303,
profiling (2.123 ms) : 2066, 2180
.   : milestone, 2123,
tracing (2.06 ms) : 2007, 2114
.   : milestone, 2060,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	3.812 ms [3.592 ms, 4.033 ms]	2.337 ms (158.4%)
iast	2.258 ms [2.189 ms, 2.328 ms]	782.851 µs (53.1%)
iast_GLOBAL	2.305 ms [2.235 ms, 2.375 ms]	829.405 µs (56.2%)
profiling	2.091 ms [2.036 ms, 2.146 ms]	615.483 µs (41.7%)
tracing	2.063 ms [2.009 ms, 2.117 ms]	587.64 µs (39.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.49 ms]	-
appsec	3.794 ms [3.571 ms, 4.018 ms]	2.316 ms (156.7%)
iast	2.265 ms [2.196 ms, 2.335 ms]	787.345 µs (53.3%)
iast_GLOBAL	2.303 ms [2.234 ms, 2.373 ms]	825.418 µs (55.8%)
profiling	2.123 ms [2.066 ms, 2.18 ms]	644.781 µs (43.6%)
tracing	2.06 ms [2.007 ms, 2.114 ms]	582.21 µs (39.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a1992da809, baseline=1.60.0-SNAPSHOT~2fa3c0c243
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
appsec (15.042 s) : 15042000, 15042000
.   : milestone, 15042000,
iast (18.274 s) : 18274000, 18274000
.   : milestone, 18274000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
.   : milestone, 18067000,
profiling (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
tracing (14.801 s) : 14801000, 14801000
.   : milestone, 14801000,
section candidate
no_agent (15.649 s) : 15649000, 15649000
.   : milestone, 15649000,
appsec (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
iast (18.145 s) : 18145000, 18145000
.   : milestone, 18145000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
.   : milestone, 17891000,
profiling (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
tracing (14.844 s) : 14844000, 14844000
.   : milestone, 14844000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.071 s [15.071 s, 15.071 s]	-
appsec	15.042 s [15.042 s, 15.042 s]	-29.0 ms (-0.2%)
iast	18.274 s [18.274 s, 18.274 s]	3.203 s (21.3%)
iast_GLOBAL	18.067 s [18.067 s, 18.067 s]	2.996 s (19.9%)
profiling	14.871 s [14.871 s, 14.871 s]	-200.0 ms (-1.3%)
tracing	14.801 s [14.801 s, 14.801 s]	-270.0 ms (-1.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.649 s [15.649 s, 15.649 s]	-
appsec	14.97 s [14.97 s, 14.97 s]	-679.0 ms (-4.3%)
iast	18.145 s [18.145 s, 18.145 s]	2.496 s (15.9%)
iast_GLOBAL	17.891 s [17.891 s, 17.891 s]	2.242 s (14.3%)
profiling	14.928 s [14.928 s, 14.928 s]	-721.0 ms (-4.6%)
tracing	14.844 s [14.844 s, 14.844 s]	-805.0 ms (-5.1%)

github-actions · 2026-02-18T22:46:50Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

ygree

Looks good!

AlexeyKuznetsov-DD · 2026-02-19T03:34:58Z

...s-1.1/src/main/java/datadog/trace/instrumentation/jms/JMSMessageConsumerInstrumentation.java

+  public static class JMSLogger {
+    private static final Logger log = LoggerFactory.getLogger(JMSLogger.class);


just curious, why we need a separate static class here and static function for 1 debug message...

adding logging

d58e8d7

ygree reviewed Feb 18, 2026

View reviewed changes

ygree requested changes Feb 18, 2026

View reviewed changes

adding wrapper to avoid bytebuddy issues

1b7234d

mhlidd added inst: jms JMS instrumentation comp: logging Tracer internal logging labels Feb 18, 2026

PR comments

4b360cc

mhlidd requested a review from ygree February 18, 2026 22:46

mhlidd marked this pull request as ready for review February 18, 2026 22:46

mhlidd requested review from a team as code owners February 18, 2026 22:46

mhlidd requested review from mtoffl01 and removed request for a team February 18, 2026 22:46

mhlidd added the type: enhancement Enhancements and improvements label Feb 18, 2026

Merge branch 'master' into mhlidd/add_jms_logging

a1992da

ygree approved these changes Feb 18, 2026

View reviewed changes

AlexeyKuznetsov-DD reviewed Feb 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Logging for JMS `ITERATION` Scope#10632

Adding Logging for JMS `ITERATION` Scope#10632
mhlidd wants to merge 4 commits intomasterfrom
mhlidd/add_jms_logging

mhlidd commented Feb 18, 2026 •

edited

Loading

Uh oh!

ygree Feb 18, 2026 •

edited

Loading

Uh oh!

ygree Feb 18, 2026

Uh oh!

pr-commenter bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

ygree left a comment

Uh oh!

AlexeyKuznetsov-DD Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

		public static class JMSLogger {
		private static final Logger log = LoggerFactory.getLogger(JMSLogger.class);

Conversation

mhlidd commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

ygree Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ygree Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

ygree left a comment

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

mhlidd commented Feb 18, 2026 •

edited

Loading

ygree Feb 18, 2026 •

edited

Loading

pr-commenter bot commented Feb 18, 2026 •

edited

Loading