Avoid computing merge base for PR info in DDCI legacy mode#10624
Draft
daniel-mohedano wants to merge 1 commit intomasterfrom
Draft
Avoid computing merge base for PR info in DDCI legacy mode#10624daniel-mohedano wants to merge 1 commit intomasterfrom
daniel-mohedano wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085032
Total [baseline] (8.799 s) : 0, 8798500
Agent [candidate] (1.068 s) : 0, 1068078
Total [candidate] (8.765 s) : 0, 8765423
section iast
Agent [baseline] (1.232 s) : 0, 1231726
Total [baseline] (9.329 s) : 0, 9329378
Agent [candidate] (1.23 s) : 0, 1230123
Total [candidate] (9.352 s) : 0, 9352301
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (641.208 ms) : 0, 641208
BytebuddyAgent [candidate] (629.895 ms) : 0, 629895
AgentMeter [baseline] (29.538 ms) : 0, 29538
AgentMeter [candidate] (29.183 ms) : 0, 29183
GlobalTracer [baseline] (261.273 ms) : 0, 261273
GlobalTracer [candidate] (259.047 ms) : 0, 259047
AppSec [baseline] (33.619 ms) : 0, 33619
AppSec [candidate] (33.231 ms) : 0, 33231
Debugger [baseline] (62.507 ms) : 0, 62507
Debugger [candidate] (60.225 ms) : 0, 60225
Remote Config [baseline] (630.2 µs) : 0, 630
Remote Config [candidate] (642.584 µs) : 0, 643
Telemetry [baseline] (12.332 ms) : 0, 12332
Telemetry [candidate] (13.939 ms) : 0, 13939
Flare Poller [baseline] (6.929 ms) : 0, 6929
Flare Poller [candidate] (5.366 ms) : 0, 5366
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (796.739 ms) : 0, 796739
BytebuddyAgent [candidate] (794.458 ms) : 0, 794458
AgentMeter [baseline] (11.25 ms) : 0, 11250
AgentMeter [candidate] (11.271 ms) : 0, 11271
GlobalTracer [baseline] (248.417 ms) : 0, 248417
GlobalTracer [candidate] (248.161 ms) : 0, 248161
AppSec [baseline] (32.806 ms) : 0, 32806
AppSec [candidate] (32.272 ms) : 0, 32272
Debugger [baseline] (66.46 ms) : 0, 66460
Debugger [candidate] (67.844 ms) : 0, 67844
Remote Config [baseline] (539.495 µs) : 0, 539
Remote Config [candidate] (531.961 µs) : 0, 532
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.67 ms) : 0, 8670
Flare Poller [baseline] (3.46 ms) : 0, 3460
Flare Poller [candidate] (3.509 ms) : 0, 3509
IAST [baseline] (27.047 ms) : 0, 27047
IAST [candidate] (26.926 ms) : 0, 26926
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084257
Total [baseline] (11.019 s) : 0, 11018626
Agent [candidate] (1.062 s) : 0, 1061597
Total [candidate] (10.862 s) : 0, 10862476
section appsec
Agent [baseline] (1.244 s) : 0, 1244474
Total [baseline] (11.051 s) : 0, 11051286
Agent [candidate] (1.24 s) : 0, 1239993
Total [candidate] (10.984 s) : 0, 10983526
section iast
Agent [baseline] (1.233 s) : 0, 1233109
Total [baseline] (11.105 s) : 0, 11105378
Agent [candidate] (1.233 s) : 0, 1233384
Total [candidate] (11.154 s) : 0, 11153588
section profiling
Agent [baseline] (1.189 s) : 0, 1188766
Total [baseline] (10.869 s) : 0, 10868533
Agent [candidate] (1.199 s) : 0, 1198926
Total [candidate] (10.979 s) : 0, 10978852
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (639.88 ms) : 0, 639880
BytebuddyAgent [candidate] (627.39 ms) : 0, 627390
AgentMeter [baseline] (29.692 ms) : 0, 29692
AgentMeter [candidate] (28.869 ms) : 0, 28869
GlobalTracer [baseline] (261.919 ms) : 0, 261919
GlobalTracer [candidate] (256.959 ms) : 0, 256959
AppSec [baseline] (33.638 ms) : 0, 33638
AppSec [candidate] (32.867 ms) : 0, 32867
Debugger [baseline] (65.468 ms) : 0, 65468
Debugger [candidate] (61.657 ms) : 0, 61657
Remote Config [baseline] (627.031 µs) : 0, 627
Remote Config [candidate] (628.412 µs) : 0, 628
Telemetry [baseline] (11.645 ms) : 0, 11645
Telemetry [candidate] (10.735 ms) : 0, 10735
Flare Poller [baseline] (4.658 ms) : 0, 4658
Flare Poller [candidate] (6.073 ms) : 0, 6073
section appsec
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (658.075 ms) : 0, 658075
BytebuddyAgent [candidate] (657.449 ms) : 0, 657449
AgentMeter [baseline] (12.072 ms) : 0, 12072
AgentMeter [candidate] (12.051 ms) : 0, 12051
GlobalTracer [baseline] (260.626 ms) : 0, 260626
GlobalTracer [candidate] (258.89 ms) : 0, 258890
AppSec [baseline] (169.612 ms) : 0, 169612
AppSec [candidate] (169.09 ms) : 0, 169090
Debugger [baseline] (67.66 ms) : 0, 67660
Debugger [candidate] (66.489 ms) : 0, 66489
Remote Config [baseline] (653.21 µs) : 0, 653
Remote Config [candidate] (659.396 µs) : 0, 659
Telemetry [baseline] (9.746 ms) : 0, 9746
Telemetry [candidate] (9.793 ms) : 0, 9793
Flare Poller [baseline] (3.807 ms) : 0, 3807
Flare Poller [candidate] (3.794 ms) : 0, 3794
IAST [baseline] (25.724 ms) : 0, 25724
IAST [candidate] (25.287 ms) : 0, 25287
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (796.194 ms) : 0, 796194
BytebuddyAgent [candidate] (797.167 ms) : 0, 797167
AgentMeter [baseline] (11.288 ms) : 0, 11288
AgentMeter [candidate] (11.287 ms) : 0, 11287
GlobalTracer [baseline] (248.227 ms) : 0, 248227
GlobalTracer [candidate] (248.267 ms) : 0, 248267
AppSec [baseline] (34.016 ms) : 0, 34016
AppSec [candidate] (34.04 ms) : 0, 34040
Debugger [baseline] (67.159 ms) : 0, 67159
Debugger [candidate] (66.558 ms) : 0, 66558
Remote Config [baseline] (543.592 µs) : 0, 544
Remote Config [candidate] (534.421 µs) : 0, 534
Telemetry [baseline] (8.542 ms) : 0, 8542
Telemetry [candidate] (8.601 ms) : 0, 8601
Flare Poller [baseline] (3.485 ms) : 0, 3485
Flare Poller [candidate] (3.45 ms) : 0, 3450
IAST [baseline] (27.172 ms) : 0, 27172
IAST [candidate] (27.086 ms) : 0, 27086
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (681.667 ms) : 0, 681667
BytebuddyAgent [candidate] (688.287 ms) : 0, 688287
AgentMeter [baseline] (8.613 ms) : 0, 8613
AgentMeter [candidate] (8.68 ms) : 0, 8680
GlobalTracer [baseline] (215.554 ms) : 0, 215554
GlobalTracer [candidate] (217.325 ms) : 0, 217325
AppSec [baseline] (32.502 ms) : 0, 32502
AppSec [candidate] (33.073 ms) : 0, 33073
Debugger [baseline] (67.457 ms) : 0, 67457
Debugger [candidate] (67.436 ms) : 0, 67436
Remote Config [baseline] (614.587 µs) : 0, 615
Remote Config [candidate] (631.91 µs) : 0, 632
Telemetry [baseline] (8.89 ms) : 0, 8890
Telemetry [candidate] (8.991 ms) : 0, 8991
Flare Poller [baseline] (3.744 ms) : 0, 3744
Flare Poller [candidate] (3.793 ms) : 0, 3793
ProfilingAgent [baseline] (98.712 ms) : 0, 98712
ProfilingAgent [candidate] (99.186 ms) : 0, 99186
Profiling [baseline] (99.279 ms) : 0, 99279
Profiling [candidate] (99.749 ms) : 0, 99749
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.351 ms) : 3308, 3394
. : milestone, 3351,
iast_FULL (5.658 ms) : 5602, 5714
. : milestone, 5658,
iast_GLOBAL (3.612 ms) : 3552, 3672
. : milestone, 3612,
profiling (2.05 ms) : 2032, 2068
. : milestone, 2050,
tracing (1.791 ms) : 1776, 1806
. : milestone, 1791,
section candidate
no_agent (1.174 ms) : 1162, 1185
. : milestone, 1174,
iast (3.144 ms) : 3103, 3186
. : milestone, 3144,
iast_FULL (6.118 ms) : 6055, 6182
. : milestone, 6118,
iast_GLOBAL (3.418 ms) : 3371, 3466
. : milestone, 3418,
profiling (2.144 ms) : 2123, 2164
. : milestone, 2144,
tracing (1.819 ms) : 1804, 1834
. : milestone, 1819,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section baseline
no_agent (19.875 ms) : 19668, 20083
. : milestone, 19875,
appsec (18.655 ms) : 18467, 18842
. : milestone, 18655,
code_origins (18.572 ms) : 18389, 18755
. : milestone, 18572,
iast (17.42 ms) : 17247, 17592
. : milestone, 17420,
profiling (19.595 ms) : 19401, 19789
. : milestone, 19595,
tracing (17.862 ms) : 17684, 18040
. : milestone, 17862,
section candidate
no_agent (19.116 ms) : 18925, 19307
. : milestone, 19116,
appsec (19.121 ms) : 18930, 19311
. : milestone, 19121,
code_origins (17.681 ms) : 17505, 17858
. : milestone, 17681,
iast (17.624 ms) : 17452, 17796
. : milestone, 17624,
profiling (18.843 ms) : 18653, 19033
. : milestone, 18843,
tracing (17.886 ms) : 17708, 18064
. : milestone, 17886,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section baseline
no_agent (15.682 s) : 15682000, 15682000
. : milestone, 15682000,
appsec (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
iast (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
iast_GLOBAL (17.661 s) : 17661000, 17661000
. : milestone, 17661000,
profiling (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
section candidate
no_agent (15.466 s) : 15466000, 15466000
. : milestone, 15466000,
appsec (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
iast (17.694 s) : 17694000, 17694000
. : milestone, 17694000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
. : milestone, 17856000,
profiling (15.117 s) : 15117000, 15117000
. : milestone, 15117000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~c32c221397, baseline=1.60.0-SNAPSHOT~36ff528d76
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.785 ms) : 3563, 4008
. : milestone, 3785,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.293 ms) : 2223, 2362
. : milestone, 2293,
profiling (2.075 ms) : 2021, 2130
. : milestone, 2075,
tracing (2.071 ms) : 2017, 2125
. : milestone, 2071,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.787 ms) : 3565, 4010
. : milestone, 3787,
iast (2.258 ms) : 2189, 2327
. : milestone, 2258,
iast_GLOBAL (2.294 ms) : 2224, 2364
. : milestone, 2294,
profiling (2.102 ms) : 2046, 2158
. : milestone, 2102,
tracing (2.073 ms) : 2019, 2127
. : milestone, 2073,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
In legacy mode, the
TARGET_SHAenvvar doesn't contain the expected value, causing the computing merge base when running on a PR to either have an unexpected value or fail altogether.Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.