Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062353
Total [baseline] (8.718 s) : 0, 8717623
Agent [candidate] (1.062 s) : 0, 1062134
Total [candidate] (8.709 s) : 0, 8708881
section iast
Agent [baseline] (1.23 s) : 0, 1229686
Total [baseline] (9.355 s) : 0, 9354524
Agent [candidate] (1.247 s) : 0, 1246817
Total [candidate] (9.49 s) : 0, 9489648
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (626.691 ms) : 0, 626691
BytebuddyAgent [candidate] (626.514 ms) : 0, 626514
AgentMeter [baseline] (29.037 ms) : 0, 29037
AgentMeter [candidate] (29.001 ms) : 0, 29001
GlobalTracer [baseline] (256.833 ms) : 0, 256833
GlobalTracer [candidate] (256.754 ms) : 0, 256754
AppSec [baseline] (33.104 ms) : 0, 33104
AppSec [candidate] (32.826 ms) : 0, 32826
Debugger [baseline] (62.658 ms) : 0, 62658
Debugger [candidate] (64.224 ms) : 0, 64224
Remote Config [baseline] (628.678 µs) : 0, 629
Remote Config [candidate] (593.336 µs) : 0, 593
Telemetry [baseline] (10.652 ms) : 0, 10652
Telemetry [candidate] (8.995 ms) : 0, 8995
Flare Poller [baseline] (5.418 ms) : 0, 5418
Flare Poller [candidate] (6.043 ms) : 0, 6043
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (794.724 ms) : 0, 794724
BytebuddyAgent [candidate] (806.524 ms) : 0, 806524
AgentMeter [baseline] (11.339 ms) : 0, 11339
AgentMeter [candidate] (11.775 ms) : 0, 11775
GlobalTracer [baseline] (247.186 ms) : 0, 247186
GlobalTracer [candidate] (250.491 ms) : 0, 250491
AppSec [baseline] (32.982 ms) : 0, 32982
AppSec [candidate] (31.056 ms) : 0, 31056
Debugger [baseline] (66.49 ms) : 0, 66490
Debugger [candidate] (69.23 ms) : 0, 69230
Remote Config [baseline] (539.033 µs) : 0, 539
Remote Config [candidate] (542.303 µs) : 0, 542
Telemetry [baseline] (8.655 ms) : 0, 8655
Telemetry [candidate] (8.65 ms) : 0, 8650
Flare Poller [baseline] (3.472 ms) : 0, 3472
Flare Poller [candidate] (3.518 ms) : 0, 3518
IAST [baseline] (27.064 ms) : 0, 27064
IAST [candidate] (27.546 ms) : 0, 27546
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063124
Total [baseline] (10.827 s) : 0, 10827092
Agent [candidate] (1.064 s) : 0, 1064314
Total [candidate] (10.83 s) : 0, 10829630
section appsec
Agent [baseline] (1.238 s) : 0, 1238143
Total [baseline] (10.971 s) : 0, 10971306
Agent [candidate] (1.242 s) : 0, 1241981
Total [candidate] (11.002 s) : 0, 11001604
section iast
Agent [baseline] (1.239 s) : 0, 1238999
Total [baseline] (11.24 s) : 0, 11240174
Agent [candidate] (1.236 s) : 0, 1235839
Total [candidate] (11.321 s) : 0, 11320912
section profiling
Agent [baseline] (1.198 s) : 0, 1198134
Total [baseline] (11.02 s) : 0, 11019809
Agent [candidate] (1.187 s) : 0, 1187315
Total [candidate] (10.934 s) : 0, 10934469
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (625.867 ms) : 0, 625867
BytebuddyAgent [candidate] (626.997 ms) : 0, 626997
AgentMeter [baseline] (29.024 ms) : 0, 29024
AgentMeter [candidate] (29.06 ms) : 0, 29060
GlobalTracer [baseline] (256.792 ms) : 0, 256792
GlobalTracer [candidate] (257.632 ms) : 0, 257632
AppSec [baseline] (33.052 ms) : 0, 33052
AppSec [candidate] (33.065 ms) : 0, 33065
Debugger [baseline] (65.732 ms) : 0, 65732
Debugger [candidate] (64.62 ms) : 0, 64620
Remote Config [baseline] (605.503 µs) : 0, 606
Remote Config [candidate] (623.415 µs) : 0, 623
Telemetry [baseline] (10.482 ms) : 0, 10482
Telemetry [candidate] (11.455 ms) : 0, 11455
Flare Poller [baseline] (4.471 ms) : 0, 4471
Flare Poller [candidate] (3.732 ms) : 0, 3732
section appsec
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (657.636 ms) : 0, 657636
BytebuddyAgent [candidate] (659.329 ms) : 0, 659329
AgentMeter [baseline] (11.919 ms) : 0, 11919
AgentMeter [candidate] (12.038 ms) : 0, 12038
GlobalTracer [baseline] (257.329 ms) : 0, 257329
GlobalTracer [candidate] (258.995 ms) : 0, 258995
AppSec [baseline] (168.426 ms) : 0, 168426
AppSec [candidate] (168.377 ms) : 0, 168377
Debugger [baseline] (66.563 ms) : 0, 66563
Debugger [candidate] (66.756 ms) : 0, 66756
Remote Config [baseline] (663.288 µs) : 0, 663
Remote Config [candidate] (642.331 µs) : 0, 642
Telemetry [baseline] (9.293 ms) : 0, 9293
Telemetry [candidate] (9.409 ms) : 0, 9409
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.706 ms) : 0, 3706
IAST [baseline] (25.474 ms) : 0, 25474
IAST [candidate] (25.487 ms) : 0, 25487
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (800.808 ms) : 0, 800808
BytebuddyAgent [candidate] (799.119 ms) : 0, 799119
AgentMeter [baseline] (11.584 ms) : 0, 11584
AgentMeter [candidate] (11.529 ms) : 0, 11529
GlobalTracer [baseline] (248.635 ms) : 0, 248635
GlobalTracer [candidate] (247.959 ms) : 0, 247959
AppSec [baseline] (32.576 ms) : 0, 32576
AppSec [candidate] (32.959 ms) : 0, 32959
Debugger [baseline] (68.224 ms) : 0, 68224
Debugger [candidate] (67.449 ms) : 0, 67449
Remote Config [baseline] (535.299 µs) : 0, 535
Remote Config [candidate] (529.766 µs) : 0, 530
Telemetry [baseline] (8.655 ms) : 0, 8655
Telemetry [candidate] (8.618 ms) : 0, 8618
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.451 ms) : 0, 3451
IAST [baseline] (27.285 ms) : 0, 27285
IAST [candidate] (27.085 ms) : 0, 27085
section profiling
ProfilingAgent [baseline] (100.164 ms) : 0, 100164
ProfilingAgent [candidate] (99.534 ms) : 0, 99534
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (686.527 ms) : 0, 686527
BytebuddyAgent [candidate] (679.433 ms) : 0, 679433
AgentMeter [baseline] (8.591 ms) : 0, 8591
AgentMeter [candidate] (8.501 ms) : 0, 8501
GlobalTracer [baseline] (216.924 ms) : 0, 216924
GlobalTracer [candidate] (215.263 ms) : 0, 215263
AppSec [baseline] (32.739 ms) : 0, 32739
AppSec [candidate] (32.435 ms) : 0, 32435
Debugger [baseline] (67.605 ms) : 0, 67605
Debugger [candidate] (66.974 ms) : 0, 66974
Remote Config [baseline] (625.656 µs) : 0, 626
Remote Config [candidate] (636.988 µs) : 0, 637
Telemetry [baseline] (8.993 ms) : 0, 8993
Telemetry [candidate] (9.154 ms) : 0, 9154
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.81 ms) : 0, 3810
Profiling [baseline] (100.761 ms) : 0, 100761
Profiling [candidate] (100.099 ms) : 0, 100099
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section baseline
no_agent (1.215 ms) : 1203, 1227
. : milestone, 1215,
iast (3.024 ms) : 2988, 3060
. : milestone, 3024,
iast_FULL (5.738 ms) : 5681, 5796
. : milestone, 5738,
iast_GLOBAL (3.586 ms) : 3527, 3645
. : milestone, 3586,
profiling (2.045 ms) : 2026, 2064
. : milestone, 2045,
tracing (1.782 ms) : 1767, 1797
. : milestone, 1782,
section candidate
no_agent (1.195 ms) : 1184, 1207
. : milestone, 1195,
iast (3.048 ms) : 3008, 3088
. : milestone, 3048,
iast_FULL (5.718 ms) : 5662, 5775
. : milestone, 5718,
iast_GLOBAL (3.54 ms) : 3481, 3599
. : milestone, 3540,
profiling (2.212 ms) : 2190, 2235
. : milestone, 2212,
tracing (1.79 ms) : 1775, 1805
. : milestone, 1790,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section baseline
no_agent (19.24 ms) : 19041, 19440
. : milestone, 19240,
appsec (19.038 ms) : 18843, 19233
. : milestone, 19038,
code_origins (17.621 ms) : 17448, 17795
. : milestone, 17621,
iast (17.827 ms) : 17650, 18004
. : milestone, 17827,
profiling (18.371 ms) : 18186, 18557
. : milestone, 18371,
tracing (17.559 ms) : 17387, 17731
. : milestone, 17559,
section candidate
no_agent (19.279 ms) : 19077, 19481
. : milestone, 19279,
appsec (18.645 ms) : 18456, 18833
. : milestone, 18645,
code_origins (17.351 ms) : 17177, 17525
. : milestone, 17351,
iast (17.943 ms) : 17764, 18121
. : milestone, 17943,
profiling (18.708 ms) : 18521, 18895
. : milestone, 18708,
tracing (18.394 ms) : 18210, 18578
. : milestone, 18394,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.533 ms) : 2478, 2588
. : milestone, 2533,
iast (2.263 ms) : 2193, 2333
. : milestone, 2263,
iast_GLOBAL (2.311 ms) : 2241, 2381
. : milestone, 2311,
profiling (2.094 ms) : 2039, 2149
. : milestone, 2094,
tracing (2.069 ms) : 2015, 2122
. : milestone, 2069,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.824 ms) : 3603, 4045
. : milestone, 3824,
iast (2.261 ms) : 2191, 2331
. : milestone, 2261,
iast_GLOBAL (2.308 ms) : 2238, 2377
. : milestone, 2308,
profiling (2.092 ms) : 2037, 2147
. : milestone, 2092,
tracing (2.076 ms) : 2023, 2130
. : milestone, 2076,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a7f8b7662e, baseline=1.60.0-SNAPSHOT~cf973bf38e
dateFormat X
axisFormat %s
section baseline
no_agent (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
appsec (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
iast (18.737 s) : 18737000, 18737000
. : milestone, 18737000,
iast_GLOBAL (17.715 s) : 17715000, 17715000
. : milestone, 17715000,
profiling (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
tracing (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
section candidate
no_agent (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
appsec (14.717 s) : 14717000, 14717000
. : milestone, 14717000,
iast (18.579 s) : 18579000, 18579000
. : milestone, 18579000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
. : milestone, 17891000,
profiling (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
tracing (14.808 s) : 14808000, 14808000
. : milestone, 14808000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
7a4d869 to
32dba74
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
f4aa3fe to
a7f8b76
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
is the client stats part being done in a different PR? https://github.com/DataDog/datadog-agent/pull/45982/changes |
yep I will stack another PR on top |
|
could you send a few test data on datadog with this PR to double check from UI |
What Does This Do
This change introduces service name source tracking, allowing us to record which integration or feature overrides the service name on a span.
To support this, a new
setServiceNameAPI has been added toAgentSpan. In addition to the service name, this method also accepts aCharSequencerepresenting the source of the override.For durability, the old signature has been deprecated on AgentSpan. Also, a forbiddenApi check has been added to all the integration to discourage the usage of the previous method that is missing the source of override.
When a source is set on a span, it is automatically propagated to its local children, since they inherit the same service name.
Manual tracing is currently out of scope. However, in the future we may extend this mechanism to track manual overrides as a
"manual"source.If a source is present on a span, an eager post-processor records it under the
_dd.svc_srctag.Please note that trace statistics will also need to incorporate this source information. That update will be handled in a separate PR.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.