Skip to content

Conversation

@siscia
Copy link

@siscia siscia commented Jul 8, 2025

The re-exported types are considered privates.
This does not follow the specification and breaks a lot of IDEs during type checks

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Makes the package follows standard convention

Description of the Change

Adding re-exported modules to __all__

Alternate Designs

NA

Possible Drawbacks

NA

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

…test/spec/distributing.html#library-interface-public-and-private-symbols

The re-exported types are considered privates.
This does not follow the specification and breaks a lot of IDEs during type checks
@siscia siscia requested a review from a team as a code owner July 8, 2025 19:42
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale - Bot reminder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant