Skip to content

Conversation

@RiantZ
Copy link
Contributor

@RiantZ RiantZ commented Jan 8, 2026

What does this PR do?

Add core agent config option to disable Traces OTLP ingest infa-attributes-processor
https://datadoghq.atlassian.net/browse/OTAGENT-689

This is first step implementation to unblock client, perhaps clean and long term refactoring or rework will be done later to address tags duplication issue.

Motivation

Infa-attributes-processor was recently added to OTLP ingest pipeline and we have a client extra billed for 10K
https://accounts.google.com/o/saml2/idp?RelayState=https%3A%2F%2Fdatadog.zendesk.com%2Fagent%2Ftickets%2F2348854&brand_id=284865&idpid=C0147pk0i&SAMLRequest=fZFPT8JAEMXvfIpm79tu1xZhQ0saiAkJGgPqwdu6O0jj%2FsGdLaKf3lAlwUS9%0AzryXN%2FN7k%2BnBmmQPAVvvKpKnjEzrwQSlNTvRdHHrVvDaAcbkYI1D0S8q0gUn%0AvMQWhZMWUEQl1s31UvCUiV3w0StvyJnlf4dEhBBb70iymFfkaAh0rAtdjjdA%0AFdcjWjyBpCO54VTyIi8LfjG8ZEOSLBA7WDiM0sWKcMaHlOWUje7yUrBclOyR%0AJA%2Bn73jKSNKcwmbeYWchrCHsWwX3q2VFtjHuUGSZllFq%2F5x%2BgNOAL6nyNpNK%0AAWJ2vI7UPSHRp4f6F%2FUkOxd887yRFhbzW29a9Z40xvi3WQAZoSIxdECSKx%2Bs%0AjH%2BzytO8n7SabnqpACtb02gdAJFk9Vfqz%2BLqwSc%3D%0A

The PR is an attempt to address client need to give ability to roll-back to previous functionality.

Describe how you validated your changes

  • Manual tests
  • Unit tests

@RiantZ RiantZ requested a review from jade-guiton-dd January 8, 2026 15:09
@RiantZ RiantZ requested review from a team as code owners January 8, 2026 15:09
@RiantZ RiantZ added component/otlp PRs and issues related to OTLP ingest qa/done QA done before merge and regressions are covered by tests labels Jan 8, 2026
@RiantZ RiantZ requested a review from hush-hush January 8, 2026 15:09
@RiantZ RiantZ requested a review from ogaca-dd January 8, 2026 15:09
@github-actions github-actions bot added the medium review PR review might take time label Jan 8, 2026
Co-authored-by: maxime mouial <hush-hush@users.noreply.github.com>
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 56397b4
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +4.91 KiB (0.00% increase) 705.484 → 705.489 → 708.410
agent_rpm_amd64 +4.91 KiB (0.00% increase) 705.470 → 705.475 → 708.380
agent_rpm_arm64 +5.38 KiB (0.00% increase) 686.990 → 686.996 → 693.520
agent_suse_amd64 +4.91 KiB (0.00% increase) 705.470 → 705.475 → 708.380
agent_suse_arm64 +5.38 KiB (0.00% increase) 686.990 → 686.996 → 693.520
docker_agent_amd64 +4.91 KiB (0.00% increase) 767.218 → 767.223 → 770.720
docker_agent_arm64 +5.39 KiB (0.00% increase) 773.358 → 773.364 → 780.200
docker_agent_jmx_amd64 +4.91 KiB (0.00% increase) 958.097 → 958.102 → 961.600
docker_agent_jmx_arm64 +5.38 KiB (0.00% increase) 952.956 → 952.962 → 959.800
docker_dogstatsd_arm64 -64.0 KiB (0.17% reduction) 37.128 → 37.065 → 37.940
21 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 700.774 MiB
agent_heroku_amd64 326.527 MiB
agent_msi 570.926 MiB
agent_rpm_amd64_fips 700.761 MiB
agent_rpm_arm64_fips 683.129 MiB
agent_suse_amd64_fips 700.761 MiB
agent_suse_arm64_fips 683.129 MiB
docker_cluster_agent_amd64 180.749 MiB
docker_cluster_agent_arm64 196.618 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.785 MiB
dogstatsd_deb_amd64 30.004 MiB
dogstatsd_deb_arm64 28.152 MiB
dogstatsd_rpm_amd64 30.004 MiB
dogstatsd_suse_amd64 30.004 MiB
iot_agent_deb_amd64 43.002 MiB
iot_agent_deb_arm64 40.123 MiB
iot_agent_deb_armhf 40.704 MiB
iot_agent_rpm_amd64 43.003 MiB
iot_agent_suse_amd64 43.003 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +46.58 KiB (0.03% increase) 173.383 → 173.429 → 174.490
agent_deb_amd64_fips -36.45 KiB (0.02% reduction) 172.406 → 172.370 → 173.750
agent_heroku_amd64 -9.36 KiB (0.01% reduction) 87.066 → 87.057 → 88.450
agent_msi +4.0 KiB (0.00% increase) 142.758 → 142.762 → 143.020
agent_rpm_amd64 +15.41 KiB (0.01% increase) 176.077 → 176.092 → 177.660
agent_rpm_amd64_fips -12.82 KiB (0.01% reduction) 175.152 → 175.139 → 176.600
agent_rpm_arm64 -16.96 KiB (0.01% reduction) 159.478 → 159.461 → 161.260
agent_rpm_arm64_fips +31.7 KiB (0.02% increase) 158.798 → 158.829 → 160.550
agent_suse_amd64 +15.41 KiB (0.01% increase) 176.077 → 176.092 → 177.660
agent_suse_amd64_fips -12.82 KiB (0.01% reduction) 175.152 → 175.139 → 176.600
agent_suse_arm64 -16.96 KiB (0.01% reduction) 159.478 → 159.461 → 161.260
agent_suse_arm64_fips +31.7 KiB (0.02% increase) 158.798 → 158.829 → 160.550
docker_agent_amd64 -3.58 KiB (0.00% reduction) 261.021 → 261.018 → 262.450
docker_agent_arm64 -19.86 KiB (0.01% reduction) 250.071 → 250.052 → 252.630
docker_agent_jmx_amd64 -4.23 KiB (0.00% reduction) 329.668 → 329.664 → 331.080
docker_agent_jmx_arm64 -24.49 KiB (0.01% reduction) 314.697 → 314.673 → 317.270
docker_cluster_agent_amd64 +2.21 KiB (0.00% increase) 63.855 → 63.857 → 64.490
docker_cluster_agent_arm64 +2.14 KiB (0.00% increase) 60.135 → 60.137 → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB
docker_cws_instrumentation_arm64 neutral 2.726 MiB
docker_dogstatsd_amd64 neutral 15.014 MiB
docker_dogstatsd_arm64 neutral 14.341 MiB
dogstatsd_deb_amd64 neutral 7.938 MiB
dogstatsd_deb_arm64 neutral 6.813 MiB
dogstatsd_rpm_amd64 neutral 7.949 MiB
dogstatsd_suse_amd64 neutral 7.949 MiB
iot_agent_deb_amd64 neutral 11.261 MiB
iot_agent_deb_arm64 neutral 9.632 MiB
iot_agent_deb_armhf neutral 9.825 MiB
iot_agent_rpm_amd64 neutral 11.279 MiB
iot_agent_suse_amd64 neutral 11.279 MiB

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jan 8, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 23c75267-248d-4a3e-8c3c-6c5201ebd651

Baseline: 621c78c
Comparison: e518384
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -3.05 [-5.99, -0.10] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.22 [-0.25, +2.69] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +1.03 [+0.82, +1.23] 1 Logs
ddot_metrics memory utilization +0.85 [+0.62, +1.08] 1 Logs
ddot_logs memory utilization +0.44 [+0.37, +0.51] 1 Logs
docker_containers_memory memory utilization +0.39 [+0.32, +0.47] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.38 [+0.31, +0.45] 1 Logs
quality_gate_metrics_logs memory utilization +0.36 [+0.15, +0.56] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.13 [+0.07, +0.19] 1 Logs
quality_gate_idle memory utilization +0.12 [+0.07, +0.16] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.05 [+0.00, +0.09] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.03 [-0.20, +0.26] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.36, +0.42] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.34, +0.40] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.39, +0.42] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.09] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.12, +0.13] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
otlp_ingest_metrics memory utilization -0.16 [-0.31, -0.00] 1 Logs
quality_gate_idle_all_features memory utilization -0.28 [-0.31, -0.24] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.28 [-0.37, -0.20] 1 Logs
file_tree memory utilization -0.30 [-0.35, -0.24] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.47 [-0.63, -0.30] 1 Logs
docker_containers_cpu % cpu utilization -3.05 [-5.99, -0.10] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@drichards-87 drichards-87 self-assigned this Jan 8, 2026
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion from Docs for the release note and approved the PR.

@drichards-87 drichards-87 removed their assignment Jan 8, 2026
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiantZ
Copy link
Contributor Author

RiantZ commented Jan 9, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 9, 2026

View all feedbacks in Devflow UI.

2026-01-09 13:08:23 UTC ℹ️ Start processing command /merge


2026-01-09 13:08:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-01-09 13:41:49 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 928400d into main Jan 9, 2026
322 checks passed
@dd-mergequeue dd-mergequeue bot deleted the azh/otagent-689 branch January 9, 2026 13:41
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/otlp PRs and issues related to OTLP ingest medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants