-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add OTLP traces ingest infra-attr enable config option #44886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: maxime mouial <hush-hush@users.noreply.github.com>
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
21 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 621c78c Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -3.05 | [-5.99, -0.10] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.22 | [-0.25, +2.69] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +1.03 | [+0.82, +1.23] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.85 | [+0.62, +1.08] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.44 | [+0.37, +0.51] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.39 | [+0.32, +0.47] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.38 | [+0.31, +0.45] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.36 | [+0.15, +0.56] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.13 | [+0.07, +0.19] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.12 | [+0.07, +0.16] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.05 | [+0.00, +0.09] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.03 | [-0.20, +0.26] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.36, +0.42] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.03 | [-0.34, +0.40] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.39, +0.42] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.08, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.13, +0.12] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.16 | [-0.31, -0.00] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.28 | [-0.31, -0.24] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -0.28 | [-0.37, -0.20] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.30 | [-0.35, -0.24] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.47 | [-0.63, -0.30] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -3.05 | [-5.99, -0.10] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
drichards-87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion from Docs for the release note and approved the PR.
releasenotes/notes/otlp-ingest-trace-iaproc-manage-158a22f702093d6d.yaml
Outdated
Show resolved
Hide resolved
…93d6d.yaml Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
jade-guiton-dd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Add core agent config option to disable Traces OTLP ingest infa-attributes-processor
https://datadoghq.atlassian.net/browse/OTAGENT-689
This is first step implementation to unblock client, perhaps clean and long term refactoring or rework will be done later to address tags duplication issue.
Motivation
Infa-attributes-processor was recently added to OTLP ingest pipeline and we have a client extra billed for 10K
https://accounts.google.com/o/saml2/idp?RelayState=https%3A%2F%2Fdatadog.zendesk.com%2Fagent%2Ftickets%2F2348854&brand_id=284865&idpid=C0147pk0i&SAMLRequest=fZFPT8JAEMXvfIpm79tu1xZhQ0saiAkJGgPqwdu6O0jj%2FsGdLaKf3lAlwUS9%0AzryXN%2FN7k%2BnBmmQPAVvvKpKnjEzrwQSlNTvRdHHrVvDaAcbkYI1D0S8q0gUn%0AvMQWhZMWUEQl1s31UvCUiV3w0StvyJnlf4dEhBBb70iymFfkaAh0rAtdjjdA%0AFdcjWjyBpCO54VTyIi8LfjG8ZEOSLBA7WDiM0sWKcMaHlOWUje7yUrBclOyR%0AJA%2Bn73jKSNKcwmbeYWchrCHsWwX3q2VFtjHuUGSZllFq%2F5x%2BgNOAL6nyNpNK%0AAWJ2vI7UPSHRp4f6F%2FUkOxd887yRFhbzW29a9Z40xvi3WQAZoSIxdECSKx%2Bs%0AjH%2BzytO8n7SabnqpACtb02gdAJFk9Vfqz%2BLqwSc%3D%0A
The PR is an attempt to address client need to give ability to roll-back to previous functionality.
Describe how you validated your changes