fix: add validation for empty email and password in DPP credentials #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the UI bugs that occur when users submit an empty password during credential entry. The application previously accepted invalid input and became unresponsive. Changes: - Add validation in get_dpp_creds() to reject empty email/password - Add safety check in login_to_dpp_server() for empty credentials - Add validation in subscription_routine() when reading from file - Remove invalid credential files that contain empty values - Add proper error messages for validation failures - Fix credential file overwrite (use > instead of >> for first line) - Add proper quoting for variables and stderr redirection Fixes: Dasharo/dasharo-issues#1326 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
m-iwanicki
requested changes
Jan 12, 2026
| echo "" | ||
| read -p "Enter password: " 'DPP_PASSWORD' | ||
|
|
||
| # Validate that email is not empty |
Contributor
There was a problem hiding this comment.
Move this check before asking for password, let's fail immediately. That way OSFV tests should pass without any changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the UI bugs that occur when users submit an empty password during DPP credential entry (Dasharo/dasharo-issues#1326).
Problem: When users entered an empty password, the application:
mc: <ERROR> Unable to list folder. Access DeniedmessagesSolution:
get_dpp_creds()to reject empty email/password with clear error messageslogin_to_dpp_server()for empty credentialssubscription_routine()when reading credentials from file>instead of>>for first line)Test plan
mcerror messages are shownFixes: Dasharo/dasharo-issues#1326
🤖 Generated with Claude Code