Fix specular with material system #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
illwieckz
reviewed
Nov 20, 2024
| /* Reflective specular setting is different here than in ProcessMaterialLightMapping(), | ||
| because we don't have cubemaps built yet at this point, but for the purposes of the material ordering there's no difference */ | ||
| gl_lightMappingShaderMaterial->SetReflectiveSpecular( material->enableSpecularMapping && !( tr.refdef.rdflags & RDF_NOCUBEMAP ) ); | ||
| gl_lightMappingShaderMaterial->SetReflectiveSpecular( glConfig2.reflectionMapping && material->enableSpecularMapping && !( tr.refdef.rdflags & RDF_NOCUBEMAP ) ); |
Member
There was a problem hiding this comment.
Maybe there is a way to test for glConfig2.reflectionMapping when setting material->enableSpecularMapping earlier? Anyway, this is not blocking.
Member
There was a problem hiding this comment.
You can use specular mapping while reflection mapping is disabled. That's the broken case.
Member
There was a problem hiding this comment.
Ah I see, for some reasons my mind misread glConfig2.specularMapping instead. 😅️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1440.