Clean up snapshot mess with #including gamelogic #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shared header defined snapshot_t which was used in both the client and cgame, but with different definitions of the player state struct. For the cgame definition of playerState_t it included the file shared/bg_public.h from the gamelogic. Instead of this define an ipcSnapshot_t type which has a consistent definition and is used for IPC messages. Now snapshot_t will be defined and used only in the cgame.
Contributor
|
This can be rebased on |
Member
Author
Not needed, it doesn't change the ABI. |
Member
Author
|
@illwieckz Does the LGTM on #1430 apply to this also? |
Member
Author
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shared header defined snapshot_t which was used in both the client and cgame, but with different definitions of the player state struct. For the cgame definition of playerState_t it included the file shared/bg_public.h from the gamelogic.
Instead of this define an ipcSnapshot_t type which has a consistent definition and is used for IPC messages. Now snapshot_t will be defined and used only in the cgame.
Companion: Unvanquished/Unvanquished#3182