Skip to content

Conversation

@Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Oct 28, 2025

Closes #1937

Some of the function in the vtk-writer had misleading and unnecessary fields in the interface. This PR fixes it.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.63%. Comparing base (d360380) to head (b7a7cec).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/t8_vtk/t8_vtk_writer_helper.cxx 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   75.77%   75.63%   -0.15%     
==========================================
  Files         103      103              
  Lines       19230    18625     -605     
==========================================
- Hits        14572    14087     -485     
+ Misses       4658     4538     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (e5ab1b8) to head (535e7c1).
⚠️ Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
src/t8_vtk/t8_vtk_writer_helper.cxx 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   77.47%   77.46%   -0.01%     
==========================================
  Files         112      112              
  Lines       19088    19090       +2     
==========================================
  Hits        14788    14788              
- Misses       4300     4302       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandro-elsweijer
Copy link
Member

Ahhh merge conflicts @Davknapp

@sandro-elsweijer sandro-elsweijer added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 46c728d Jan 22, 2026
38 of 39 checks passed
@sandro-elsweijer sandro-elsweijer deleted the fix-vtk_output branch January 22, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Vtk-writer

3 participants