-
Notifications
You must be signed in to change notification settings - Fork 63
Improvement: Vtk-writer #1936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Vtk-writer #1936
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
- Coverage 75.77% 75.63% -0.15%
==========================================
Files 103 103
Lines 19230 18625 -605
==========================================
- Hits 14572 14087 -485
+ Misses 4658 4538 -120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
- Coverage 77.47% 77.46% -0.01%
==========================================
Files 112 112
Lines 19088 19090 +2
==========================================
Hits 14788 14788
- Misses 4300 4302 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ahhh merge conflicts @Davknapp |
Closes #1937
Some of the function in the vtk-writer had misleading and unnecessary fields in the interface. This PR fixes it.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).