Skip to content

Conversation

@alexandercyu
Copy link
Contributor

  • Adds the logo from Discourse that contains the text "Marble" in the logo.
  • Create custom css file to set size of logo
  • Remove png version of the logo

Add custom class to target logo and set size
Add Marble logo from discourse
Delete png version of logo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't this this is necessary and these attributes are overridden by other css:

  • height is unset for the logo_img class which overrides this setting
  • max-width is set to 100% and the parent of this element never gets larger than about 230px so the width you're setting here is basically ignored.

What are you trying to achieve here? Maybe there's a better way to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to set the dimensions of the image. I had tested it before by setting it to 100px and it worked. I just assumed the size of the image shown was accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants