-
Notifications
You must be signed in to change notification settings - Fork 116
Expand Alarm Configuration Actions #3682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…n the dialog and not shared with the action
|
Is there a way to suppress the context menu? Maybe that's already in the contribution support, I forgot. Or somehow tie this to authorization for the alarm configuration? In any case, for our setup I don't want to have "Add to alarm tree" in every PV context menu. |
…context menu action
|
I can add a preference for this, the framework already exists in the ContextMenuAction interface While I agree that alarm configurations should be made thoughtfully... this context menu is just making the current "add component" action from the alarm tree, which does allow specifying multiple PVs, a little bit easier to access. |
|
by simplifying this workflow I am hoping to avoid other programmatic/scripted solutions which have been necessary when adding a large number of PV's...a workflow which is even future away from the thoughtful user actions :) The authorization part is a valid issue which might need a bit more thought |
|
I'm quite sure authorization and authentication is needed for ESS to put this to use. My users have already expressed a requirement to limit access to the menu item to remove nodes. I would be happy to contribute. As for the context menu: in save&restore access to certain actions requires an authenticated session. Maybe such a scheme could be used to hide the context menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like fxml (the new add dialog), but I guess that ideally the alarm tree UI should then also be fxml...


Checklist
Testing:
Documentation: