Skip to content

fix: _get_attr -> __getattr__ and version bump #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
costowell merged 2 commits into from
Oct 8, 2025
Merged

fix: _get_attr -> __getattr__ and version bump #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc71970
fix: _get_attr -> __getattr__
costowell Oct 8, 2025
101b654
bump: 2.5.1
costowell Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
Adam Brewer <adamhb321@gmail.com>
Cole Stowell <cole@stowell.pro>
Devin Matte <devinmatte@gmail.com>
Galen Guyer <galen@galenguyer.com>
Cole Stowell <cole@stowell.pro>
Jordan Rodgers <com6056@gmail.com>
Liam Middlebrook <liammiddlebrook@gmail.com>
Marc Billow <mbillow@me.com>
Max Meinhold <mxmeinhold@gmail.com>
Michael Francis <mikefrancis95@gmail.com>
Tyler Allen <tyler@tallen.me>
William Stevens <contact@wastevensv.com>
5 changes: 5 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGES
=======

2.5.1
-----

* fix: _get_attr -> __getattr__

2.5.0
-----

Expand Down
4 changes: 2 additions & 2 deletions csh_ldap/member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def get(self, key):
Arguments:
key -- the attribute to get the value of
"""
return self._get_attr(key, as_list=True)
return self.__getattr__(key, as_list=True) # pylint: disable=unnecessary-dunder-call

@reconnect_on_fail
def groups(self):
Expand Down Expand Up @@ -91,7 +91,7 @@ def get_dn(self):
return self.__dn__

@reconnect_on_fail
def _get_attr(self, key, as_list=False):
def __getattr__(self, key, as_list=False):
res = self.__con__.search_s(
self.__dn__,
ldap.SCOPE_BASE,
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description = CSH LDAP ORM
long_description = file: README.md
long_description_content_type = text/markdown
license = MIT
version = 2.5.0
version = 2.5.1
classifier =
Natural Language :: English
Operating System :: POSIX :: Linux