Skip to content
This repository was archived by the owner on Oct 12, 2020. It is now read-only.

Conversation

@justing0927
Copy link

No description provided.

Copy link
Member

@RamZallan RamZallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the project is on GitHub, could you add a link (links in Markdown: [link text here](link url here)) somewhere to it?

github: https://github.com/justing0927
---
# Summary
D&D Make-A-Map is a web-app built using the Create React App, made to randomly generate d&d maps with various biomes and obstacles with the click of a button (or 3).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rephrase to the Create React App library

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the first time you say D&D say Dungeons & Dragons, for reference for the rest of the post

# Summary
D&D Make-A-Map is a web-app built using the Create React App, made to randomly generate d&d maps with various biomes and obstacles with the click of a button (or 3).
It's built using Node.JS and has documentation on how to build it locally or as a server.
The application utilizes JSX, html, and javascript and user input to create it's random maps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html -> HTML
javascript -> JavaScript

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's random maps -> its random maps

# The Journey

D&D Battlemaps can be frustrating. Either you spend hours to settle for an imperfect map, you spend significant time drawing out a map during the session
to fit your needs, or even forgo the map altogether. Oftentimes, you only need a quick, concrete, place to get one's bearings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comma after concrete


D&D Battlemaps can be frustrating. Either you spend hours to settle for an imperfect map, you spend significant time drawing out a map during the session
to fit your needs, or even forgo the map altogether. Oftentimes, you only need a quick, concrete, place to get one's bearings.
It's even worse for unexpected encounters where you need a map. So, I set out to do what needed done.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you need the sentence So, I set out to do what needed done.

D&D Battlemaps can be frustrating. Either you spend hours to settle for an imperfect map, you spend significant time drawing out a map during the session
to fit your needs, or even forgo the map altogether. Oftentimes, you only need a quick, concrete, place to get one's bearings.
It's even worse for unexpected encounters where you need a map. So, I set out to do what needed done.
I wanted to have something that could quickly generate a map based on a biome and some other input parameters, like for obstacles (and I think it turned out pretty alright).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the (and I think... parenthetical

it was a popular front-end app deal.
It took hours to start getting anything done, but I learned a lot in the process about HTML, Javascript, states, buttons, and how exactly not to organize the code
for a web-app. This is where I met the first big roadblock.
I was starting nearly from scratch (the Create React App helpfully creates the necessary files and an example page), and needed to figure out how to DO things.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO -> do

It took hours to start getting anything done, but I learned a lot in the process about HTML, Javascript, states, buttons, and how exactly not to organize the code
for a web-app. This is where I met the first big roadblock.
I was starting nearly from scratch (the Create React App helpfully creates the necessary files and an example page), and needed to figure out how to DO things.
Hours of tutorials, trial and error, and I finally understood how to set a components state and have that change things.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components -> component's

I was starting nearly from scratch (the Create React App helpfully creates the necessary files and an example page), and needed to figure out how to DO things.
Hours of tutorials, trial and error, and I finally understood how to set a components state and have that change things.

So, I had gotten buttons working! Options! Input values! The keys to doing somethign!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somethign -> something


So, I had gotten buttons working! Options! Input values! The keys to doing somethign!
All that was left was creating the actual map, and displaying it correctly, how hard could that be?
Of course, that's the essence of the project, and it had me stumped for awhile. The second biggest roadblock.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword the end of this sentence to be like
Of course, that's the essence of the project, and it had me stumped for awhile, which was the second biggest roadblock.

So, I had gotten buttons working! Options! Input values! The keys to doing somethign!
All that was left was creating the actual map, and displaying it correctly, how hard could that be?
Of course, that's the essence of the project, and it had me stumped for awhile. The second biggest roadblock.
But hey, eventually after hours of researching and trying things from button groups to a crazy attempt to display each object individually, I stumbled on html tables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, just start the sentence with Eventually,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants