This repository was archived by the owner on Oct 12, 2020. It is now read-only.
Create 2018-04-03-smashnotify.md #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csssuf
suggested changes
Apr 7, 2018
Member
csssuf
left a comment
csssuf
left a comment
There was a problem hiding this comment.
Looks good. Just found a couple typos.
_posts/2018-04-03-smashnotify.md
Outdated
| author-social: | ||
| github: https://github.com/fickleEfrit | ||
| --- | ||
| SmashNotify is an app made in Python that allows people entered in tournaments on Smash.gg to receive text-message updates when they have a match they need to play! It makes use of TKinter for a GUI, pysmash to access data from Smash.gg API, and Twilio to send text messages from Python. |
Member
There was a problem hiding this comment.
s/from Smash.gg API/from the Smash.gg API/
| --- | ||
| SmashNotify is an app made in Python that allows people entered in tournaments on Smash.gg to receive text-message updates when they have a match they need to play! It makes use of TKinter for a GUI, pysmash to access data from Smash.gg API, and Twilio to send text messages from Python. | ||
|
|
||
| Before SmashNotify, I had never tried to make an app with a GUI using Python, and I had also never used any kind of wrapper for a website's API. When I first found out about pysmash, the way the API was written made it impossible to retrieve data about matches that had not already been completed, so I needed to work through all layers of the filtering and make it possible to keep these sets, and just make more parameters for what data is desired in general. |
Member
There was a problem hiding this comment.
Maybe s/keep these sets/keep unfinished sets/?
s/just make/add/
_posts/2018-04-03-smashnotify.md
Outdated
|
|
||
| After I had modified the API to the point where it was possible to get the information I wanted, I decided that SmashNotify would be much more useful if it had a GUI. Looking through the options, I decided to go with TKinter. Having some familiarity with JavaFX from my CS classes, I found TKinter to be very nice. It follows a similar kind of tree-like hierarchy for creating parts of the UI, but is much simpler for things like EventHandlers with buttons. Alongside the basic UI, I also needed a way to actually notify the user. After searching around, it seemed like Twilio was the best choice for sending messages to an actual phone, which would be important if you are away at a tournament. | ||
|
|
||
| The idea of SmashNotify is a functionality that I've often wanted when entering Smash tournaments. Smash.gg has a lot to offer over alternatives like challonge, but this is definitely a feature they could use. In the meantime, though, I figured I might as well make it for myself! It definitely is not as elegant as it could be if it was baked in directly to Smash.gg, but it's definitely the most real-world applicable application I've ever made. |
Member
There was a problem hiding this comment.
s/challonge/Challonge/
s/if it was baked in/if it were baked in/
Member
|
@csssuf can you approve the changes to see if he fixed all the typos? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.