-
Notifications
You must be signed in to change notification settings - Fork 765
New rule accounts_password_pam_modules_in_authselect_profile #14279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
179fed3 to
5213a55
Compare
...accounts/accounts-pam/accounts_password_pam_modules_in_authselect_profile/ansible/shared.yml
Show resolved
Hide resolved
This rule implements CIS RHEL 10 Benchmark v1.0.1 requirement 5.3.2.1 - Ensure active authselect profile includes pam modules. Resolves: https://issues.redhat.com/browse/OPENSCAP-6093
ba8e48c to
c05874b
Compare
...tem/accounts/accounts-pam/accounts_password_pam_modules_in_authselect_profile/bash/shared.sh
Outdated
Show resolved
Hide resolved
.../accounts-pam/accounts_password_pam_modules_in_authselect_profile/tests/rhel_correct.pass.sh
Outdated
Show resolved
Hide resolved
...accounts/accounts-pam/accounts_password_pam_modules_in_authselect_profile/ansible/shared.yml
Show resolved
Hide resolved
|
|
||
| - name: '{{{ rule_title }}} - Determine PAM profile path' | ||
| ansible.builtin.set_fact: | ||
| pam_profile_path: >- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably avoid manually editing of PAM profiles. Please check if you can replace some of the tasks that edit /pam_profile_path/ with authselect commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's possible. The authselect enable-feature and authselect disable-feature commands modify the currently selected profile, they don't modify the files in /etc/authselect/custom/.
Only modify the custom profile. This is consistent with OVAL.
This PR adds new rule
accounts_password_pam_modules_in_authselect_profile. This rule implements CIS requirement "Ensure active authselect profile includes pam modules". This requirement is a part of RHEL 8, 9 and 10 CIS. The rule is added to all profiles.The rule doesn't check PAM configuration in /etc/pam.d/system-auth or password-auth. Instead, it checks the authselect template contents in /etc/authselect.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6093