-
Notifications
You must be signed in to change notification settings - Fork 765
Add Amazon Linux 2023 DISA STIG Profile #14246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Amazon Linux 2023 DISA STIG Profile #14246
Conversation
…ew and validation of each control.
bring up to date
|
Hi @Eric-Domeier. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs further review, copy-pasted from RHEL8
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
70bb4f9 to
11a42b6
Compare
Co-authored-by: Jan Černý <jcerny@redhat.com>
fa66171 to
7e48d66
Compare
|
@Mab879 @jan-cerny I could use some input on the AIDE Database check rule. Currently when running this profile, it "passes" but when ran manually I get the following output So I guess there's really two issues here Issue 1: expected output for a "Pass" should be
Issue 2: /var/log, .bash_history are volatile paths that should probably be whitelisted in /etc/aide.conf - is there already a rule somewhere to add paths for whitelisting i'm not seeing? For the /boot/loader/entries I'm guessing the remediation script is changing something here after AIDE database is built |
| title: Amazon Linux 2023 must have the packages required for encrypting | ||
| off-loaded audit logs installed. | ||
| rules: | ||
| - package_rsyslog-gnutls_installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eric-Domeier I think this should be rsyslog-openssl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I modified the rule as such here
linux_os/guide/system/logging/package_rsyslog-gnutls_installed/rule.yml
Not sure if this is the preferred way or not though, it is correctly using rsyslog-openssl however
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also attempted to fix that one here. bordencastleadmin@0f4ebdf
| audit records off-loaded onto a different system or media from the system | ||
| being audited via rsyslog. | ||
| rules: | ||
| - rsyslog_encrypt_offload_defaultnetstreamdriver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value should be set to ossl.
See where I attempted to do that here.... bordencastleadmin@0f4ebdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think the original rule could maybe be used, then just pass in the option/variable of ossl if amazon linux 2023 instead of creating a totally new rule.
| title: Amazon Linux 2023 must enable certificate-based smart card | ||
| authentication. | ||
| rules: | ||
| - sssd_enable_smartcards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sssd must be installed first. Add package_sssd_installed rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a couple more of those sssd rules will become applicable and get remediated if this is added in. Amazon Linux 2023 does not have sssd installed by default it appears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was something strange with the overrides for the packages and the macros not working when I tried it though, I don't know why, but that's why I updated the macros here to make the sssd install work. bordencastleadmin@0f4ebdf#diff-182dc0614884550d3533d1e8d12b71afe23ffa8d96c22e3a07992754d5e13e93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the /build/al2023/product.yml it has a platform_package_overrides section, but without changing those macros it seemed to keep tying the original packages and not the overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice in builds/al2023/fixes/ansible/package_sssd_installed.yml we have this:
# platform = multi_platform_all
# reboot = false
# strategy = enable
# complexity = low
# disruption = low
- name: Gather the package facts
package_facts:
manager: auto
tags:
- DISA-STIG-AZLX-23-001290
- NIST-800-53-CM-6(a)
- enable_strategy
- low_complexity
- low_disruption
- medium_severity
- no_reboot_needed
- package_sssd_installed
- name: Ensure sssd is installed
ansible.builtin.package:
name: sssd
state: present
**when: '"sssd-common" in ansible_facts.packages'**
tags:
- DISA-STIG-AZLX-23-001290
- NIST-800-53-CM-6(a)
- enable_strategy
- low_complexity
- low_disruption
- medium_severity
- no_reboot_needed
- package_sssd_installed
sssd-common is also not installed in vanilla al2023 so might be why its not installing, looking into that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah having trouble tracking down why that "when" clause exists, but if i install sssd-common manually before running the remediation, oscap successfully applies the sssd rules. not sure if this is intended or not
controls/stig_al2023.yml
Outdated
| title: Amazon Linux 2023 must be configured to off-load audit records onto a | ||
| different system from the system being audited via syslog. | ||
| rules: | ||
| - rsyslog_remote_loghost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the rules here should be replaced with:
- service_systemd-journal-upload_enabled
- systemd_journal_upload_url
Description:
Rationale:
Amazon linux 2023 stig profile is useful for federal agencies, cmmc, fedramp etc.
Amazon Linux 2023 Department of War (Previously Department of Defense) STIG #13885
Review Hints:
This builds off of @jesseborden branch, attempts to get the --stig-viewer flag working properly.
products/al2023/overlays/srg_support.xml is just a copy paste from products/rhel8/overlays/srg_support.xml with name replaced, the content hasn't actually been checked yet.
I haven't verified the content in controls/stig_al2023.yml yet
modifies applicability templates to ensure checks are applicable for al2023
To-do