Skip to content

Conversation

@ggbecker
Copy link
Member

Description:

  • Show CCE identifiers in the HTML rendered control files.

Rationale:

Review Hints:

  • ./build_product rhel9
  • cd build
  • ninja render-policies
  • firefox rhel9/rendered-policies/cis_rhel9.html

Preview

Screenshot From 2025-10-22 15-11-26

@openshift-ci
Copy link

openshift-ci bot commented Oct 22, 2025

@ggbecker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance 1495629 link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggbecker
Copy link
Member Author

/packit retest-failed

@Mab879 Mab879 self-assigned this Oct 23, 2025
{{%- if selection in rules %}}
<li><a href="https://github.com/ComplianceAsCode/content/tree/master/{{{ rules[selection].relative_definition_location }}}">{{{ selection }}}</a>: {{{ rules[selection].title }}}</li>
<li><a href="https://github.com/ComplianceAsCode/content/tree/master/{{{ rules[selection].relative_definition_location }}}"> {{{ selection }}}</a>: {{{ rules[selection].title }}}
<ul><li>{{{ rules[selection].identifiers['cce'] }}}</li></ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add an if guard rules[selection].identifiers['cce'] so that if rule or product don't use CCE it doesn't leave a blank bullet point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@jan-cerny jan-cerny modified the milestones: 0.1.79, 0.1.80 Nov 20, 2025
@Mab879
Copy link
Member

Mab879 commented Jan 5, 2026

@ggbecker Any plans on updating this PR?

@ggbecker
Copy link
Member Author

This one should be a quick fix and we can merge it, let me do that.

@ggbecker ggbecker force-pushed the update-controls-template branch from 1495629 to 6abfec9 Compare January 19, 2026 15:43
@ggbecker ggbecker requested a review from Mab879 January 19, 2026 15:47
@ggbecker
Copy link
Member Author

Fixed via force pushing an amended commit. This is ready to merge.

@github-actions
Copy link

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants