-
Notifications
You must be signed in to change notification settings - Fork 765
Show CCE identifiers in the HTML rendered control files #14034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Show CCE identifiers in the HTML rendered control files #14034
Conversation
|
@ggbecker: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/packit retest-failed |
| {{%- if selection in rules %}} | ||
| <li><a href="https://github.com/ComplianceAsCode/content/tree/master/{{{ rules[selection].relative_definition_location }}}">{{{ selection }}}</a>: {{{ rules[selection].title }}}</li> | ||
| <li><a href="https://github.com/ComplianceAsCode/content/tree/master/{{{ rules[selection].relative_definition_location }}}"> {{{ selection }}}</a>: {{{ rules[selection].title }}} | ||
| <ul><li>{{{ rules[selection].identifiers['cce'] }}}</li></ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add an if guard rules[selection].identifiers['cce'] so that if rule or product don't use CCE it doesn't leave a blank bullet point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
|
@ggbecker Any plans on updating this PR? |
|
This one should be a quick fix and we can merge it, let me do that. |
1495629 to
6abfec9
Compare
|
Fixed via force pushing an amended commit. This is ready to merge. |
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
Description:
Rationale:
Review Hints:
Preview