Added support for pinch in/out gestures#10
Open
oryasida wants to merge 1 commit intoCoffee2CodeNL:masterfrom
Open
Added support for pinch in/out gestures#10oryasida wants to merge 1 commit intoCoffee2CodeNL:masterfrom
oryasida wants to merge 1 commit intoCoffee2CodeNL:masterfrom
Conversation
Owner
|
I was actually holding off on this one because pinch events aren't reliably picked up by libinput yet and I wanted to look if I could implement pinch/rotate events on my own via raw input, for this I'm communicating with the libinput maintainers |
Contributor
Author
|
I did notice that pinch events are a little iffy sometimes. Also played around with the rotate events pinch gestures, and noticed that the libinput_event_gesture_get_angle_delta function would sometimes return a high value if you just place to fingers and wiggle them a little (without really changing the angle between them), so doing something like volume control (when you don't wait for the fingers to lift of the pad - before receiving the end event) doesn't work nicely. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for pinch in/out gestures. libinput does differentiate between 2/3/4 fingers pinch events so adding support for all the different variations can be done, but reliably executing the different variants isn't really easy.