Fix standalone language features types #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #742, standalone language features types were broken
In monaco-editor 0.55, microsoft moved language feature namespaces to top level.
The way it's bundled also changed:
languagesnamespaceSince monaco-vscode-api is modular (each language feature can be installed separately), that file can't be used.
So instead, the api was made a bit different: instead of relyng on
monaco.typescriptobject, the namespace is exported by the standalone language feature package.before:
with monaco 0.55:
with monaco-vscode-api:
This is already how monaco-vscode-api@23.2.0 should be used, but unfortunately, the types are wrong, and
@codingame/monaco-vscode-standalone-typescript-language-featurestypes are justexport {}This MR fixes that: the types are now correct